Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Side by Side Diff: tools/gn/binary_target_generator.cc

Issue 333243004: Rename GN source_prereqs to inputs, enhance "desc" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tools/gn/action_target_generator.cc ('k') | tools/gn/command_desc.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "tools/gn/binary_target_generator.h" 5 #include "tools/gn/binary_target_generator.h"
6 6
7 #include "tools/gn/config_values_generator.h" 7 #include "tools/gn/config_values_generator.h"
8 #include "tools/gn/err.h" 8 #include "tools/gn/err.h"
9 #include "tools/gn/scope.h" 9 #include "tools/gn/scope.h"
10 #include "tools/gn/variables.h" 10 #include "tools/gn/variables.h"
(...skipping 23 matching lines...) Expand all
34 return; 34 return;
35 35
36 FillSources(); 36 FillSources();
37 if (err_->has_error()) 37 if (err_->has_error())
38 return; 38 return;
39 39
40 FillPublic(); 40 FillPublic();
41 if (err_->has_error()) 41 if (err_->has_error())
42 return; 42 return;
43 43
44 FillSourcePrereqs(); 44 FillInputs();
45 if (err_->has_error()) 45 if (err_->has_error())
46 return; 46 return;
47 47
48 FillConfigs(); 48 FillConfigs();
49 if (err_->has_error()) 49 if (err_->has_error())
50 return; 50 return;
51 51
52 // Config values (compiler flags, etc.) set directly on this target. 52 // Config values (compiler flags, etc.) set directly on this target.
53 ConfigValuesGenerator gen(&target_->config_values(), scope_, 53 ConfigValuesGenerator gen(&target_->config_values(), scope_,
54 scope_->GetSourceDir(), err_); 54 scope_->GetSourceDir(), err_);
(...skipping 12 matching lines...) Expand all
67 } 67 }
68 68
69 void BinaryTargetGenerator::FillOutputExtension() { 69 void BinaryTargetGenerator::FillOutputExtension() {
70 const Value* value = scope_->GetValue(variables::kOutputExtension, true); 70 const Value* value = scope_->GetValue(variables::kOutputExtension, true);
71 if (!value) 71 if (!value)
72 return; 72 return;
73 if (!value->VerifyTypeIs(Value::STRING, err_)) 73 if (!value->VerifyTypeIs(Value::STRING, err_))
74 return; 74 return;
75 target_->set_output_extension(value->string_value()); 75 target_->set_output_extension(value->string_value());
76 } 76 }
OLDNEW
« no previous file with comments | « tools/gn/action_target_generator.cc ('k') | tools/gn/command_desc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698