Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: tools/gn/ninja_target_writer.cc

Issue 333243004: Rename GN source_prereqs to inputs, enhance "desc" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_action_target_writer_unittest.cc ('k') | tools/gn/ninja_target_writer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_target_writer.cc
diff --git a/tools/gn/ninja_target_writer.cc b/tools/gn/ninja_target_writer.cc
index d59582e6b9b35a839bc1279c68fac0d763dfda28..b6412dcaf43629be7b77158ea9b8f51735ae207c 100644
--- a/tools/gn/ninja_target_writer.cc
+++ b/tools/gn/ninja_target_writer.cc
@@ -94,7 +94,7 @@ std::string NinjaTargetWriter::WriteInputDepsStampAndGetDep(
if (!add_script_source_as_dep &&
extra_hard_deps.empty() &&
- target_->source_prereqs().empty() &&
+ target_->inputs().empty() &&
target_->recursive_hard_deps().empty() &&
(!list_sources_as_input_deps || target_->sources().empty()))
return std::string(); // No input/hard deps.
@@ -124,7 +124,7 @@ std::string NinjaTargetWriter::WriteInputDepsStampAndGetDep(
}
// Input files are order-only deps.
- const Target::FileList& prereqs = target_->source_prereqs();
+ const Target::FileList& prereqs = target_->inputs();
for (size_t i = 0; i < prereqs.size(); i++) {
out_ << " ";
path_output_.WriteFile(out_, prereqs[i]);
« no previous file with comments | « tools/gn/ninja_action_target_writer_unittest.cc ('k') | tools/gn/ninja_target_writer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698