Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: tools/gn/ninja_action_target_writer_unittest.cc

Issue 333243004: Rename GN source_prereqs to inputs, enhance "desc" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/functions_target.cc ('k') | tools/gn/ninja_target_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_action_target_writer_unittest.cc
diff --git a/tools/gn/ninja_action_target_writer_unittest.cc b/tools/gn/ninja_action_target_writer_unittest.cc
index fefc26364a43c4d317655a295de2953326af2b94..9899e2cbb75ab1b06f183c898f36dce390a893b4 100644
--- a/tools/gn/ninja_action_target_writer_unittest.cc
+++ b/tools/gn/ninja_action_target_writer_unittest.cc
@@ -59,8 +59,7 @@ TEST(NinjaActionTargetWriter, WriteArgsSubstitutions) {
}
// Makes sure that we write sources as input dependencies for actions with
-// both sources and source_prereqs (ACTION_FOREACH treats the sources
-// differently).
+// both sources and inputs (ACTION_FOREACH treats the sources differently).
TEST(NinjaActionTargetWriter, ActionWithSources) {
TestWithScope setup;
setup.build_settings()->SetBuildDir(SourceDir("//out/Debug/"));
@@ -70,7 +69,7 @@ TEST(NinjaActionTargetWriter, ActionWithSources) {
target.action_values().set_script(SourceFile("//foo/script.py"));
target.sources().push_back(SourceFile("//foo/source.txt"));
- target.source_prereqs().push_back(SourceFile("//foo/included.txt"));
+ target.inputs().push_back(SourceFile("//foo/included.txt"));
target.action_values().outputs().push_back(
SourceFile("//out/Debug/foo.out"));
@@ -159,7 +158,7 @@ TEST(NinjaActionTargetWriter, ForEach) {
target.action_values().outputs().push_back(
SourceFile("//out/Debug/{{source_name_part}}.out"));
- target.source_prereqs().push_back(SourceFile("//foo/included.txt"));
+ target.inputs().push_back(SourceFile("//foo/included.txt"));
// Posix.
{
@@ -268,7 +267,7 @@ TEST(NinjaActionTargetWriter, ForEachWithDepfile) {
target.action_values().outputs().push_back(
SourceFile("//out/Debug/{{source_name_part}}.out"));
- target.source_prereqs().push_back(SourceFile("//foo/included.txt"));
+ target.inputs().push_back(SourceFile("//foo/included.txt"));
// Posix.
{
« no previous file with comments | « tools/gn/functions_target.cc ('k') | tools/gn/ninja_target_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698