Issue 332443004: Updated menu to hide the Managed Bookmarks to follow the folder's name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 332443004: Updated menu to hide the Managed Bookmarks to follow the folder's name. (Closed)

Created:
6 years, 6 months ago by Joao da Silva

Modified:
6 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Updated menu to hide the Managed Bookmarks to follow the folder's name. The managed bookmarks folder can have a different name depending on the signed-in status of the user. This change makes the context menu that hides this folder follow the folder's name. Also fixed a glitch where the folder name would not update if configured both via cloud policy and platform policy. BUG=49598 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277371

Patch Set 1 #

Patch Set 2 : rebase #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -4 lines)			Patch
M	chrome/app/bookmarks_strings.grdp	View		1 chunk	+8 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc	View	1	3 chunks	+9 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Joao da Silva

Found these issues while doing manual testing and UX clarified that the strings should be ...

6 years, 6 months ago (2014-06-11 19:12:38 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/332443004/20001

6 years, 6 months ago (2014-06-16 01:48:02 UTC) #4

Message was sent while issue was closed.

Change committed as 277371

Expand Messages | Collapse Messages