chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm - Issue 332443004: Updated menu to hide the Managed Bookmarks to follow the folder's name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

Issue 332443004: Updated menu to hide the Managed Bookmarks to follow the folder's name. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc ('k') | chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

index 2b2f2c63f91b704b040cea8b187ee1f2fb72a941..77d8ba115eb0b68db5053f30f785b4080cee8664 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

@@ -1224,7 +1224,16 @@ void RecordAppLaunch(Profile* profile, GURL url) {

// Creates the button for "Managed Bookmarks", but does not position it.

- (void)createManagedBookmarksButton {

if (managedBookmarksButton_.get()) {

+ // The node's title might have changed if the user signed in or out.

+ // Make sure it's up to date now.

+ const BookmarkNode* node = bookmarkClient_->managed_node();

+ NSString* title = base::SysUTF16ToNSString(node->GetTitle());

+ NSCell* cell = [managedBookmarksButton_ cell];

+ [cell setTitle:title];

+ // Its visibility may have changed too.

[self setManagedBookmarksButtonVisibility];

return;

}