Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc

Issue 332443004: Updated menu to hide the Managed Bookmarks to follow the folder's name. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/bookmarks_strings.grdp ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc
diff --git a/chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc b/chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc
index 51603e0f5c7468ceb1c5ac636ae78307cfefe5d3..ecd87cb2c771701808ed55e475a355bbe08176f4 100644
--- a/chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc
+++ b/chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc
@@ -113,7 +113,7 @@ void BookmarkContextMenuController::BuildMenu() {
IDS_BOOKMARK_BAR_SHOW_APPS_SHORTCUT);
}
AddCheckboxItem(IDC_BOOKMARK_BAR_SHOW_MANAGED_BOOKMARKS,
- IDS_BOOKMARK_BAR_SHOW_MANAGED_BOOKMARKS);
+ IDS_BOOKMARK_BAR_SHOW_MANAGED_BOOKMARKS_DEFAULT_NAME);
AddCheckboxItem(IDC_BOOKMARK_BAR_ALWAYS_SHOW, IDS_SHOW_BOOKMARK_BAR);
}
@@ -302,7 +302,8 @@ void BookmarkContextMenuController::ExecuteCommand(int id, int event_flags) {
bool BookmarkContextMenuController::IsItemForCommandIdDynamic(int command_id)
const {
return command_id == IDC_BOOKMARK_BAR_UNDO ||
- command_id == IDC_BOOKMARK_BAR_REDO;
+ command_id == IDC_BOOKMARK_BAR_REDO ||
+ command_id == IDC_BOOKMARK_BAR_SHOW_MANAGED_BOOKMARKS;
}
base::string16 BookmarkContextMenuController::GetLabelForCommandId(
@@ -315,6 +316,12 @@ base::string16 BookmarkContextMenuController::GetLabelForCommandId(
return BookmarkUndoServiceFactory::GetForProfile(profile_)->
undo_manager()->GetRedoLabel();
}
+ if (command_id == IDC_BOOKMARK_BAR_SHOW_MANAGED_BOOKMARKS) {
+ ChromeBookmarkClient* client =
+ ChromeBookmarkClientFactory::GetForProfile(profile_);
+ return l10n_util::GetStringFUTF16(IDS_BOOKMARK_BAR_SHOW_MANAGED_BOOKMARKS,
+ client->managed_node()->GetTitle());
+ }
NOTREACHED();
return base::string16();
« no previous file with comments | « chrome/app/bookmarks_strings.grdp ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698