Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 332153002: Oilpan: have GeolocationInspectorAgent persistently track its controllers. (Closed)

Created:
6 years, 6 months ago by sof
Modified:
6 years, 6 months ago
CC:
blink-reviews, mvanouwerkerk+watch_chromium.org, timvolodine
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: have GeolocationInspectorAgent persistently track its controllers. With GeolocationController (now back) on the heap, maintain a persistent set of them from GeolocationInspectorAgent. R=haraken@chromium.org,ager@chromium.org,zerny@chromium.org BUG=304341 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176202

Patch Set 1 #

Total comments: 2

Patch Set 2 : Unwrap Persistent #

Patch Set 3 : Make GeolocationClientMock also use a persistent heap hash set to its controllers #

Total comments: 2

Patch Set 4 : Make hash sets over controllers will-be-persistents #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M Source/modules/geolocation/GeolocationInspectorAgent.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/geolocation/GeolocationInspectorAgent.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/geolocation/testing/GeolocationClientMock.h View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M Source/modules/geolocation/testing/GeolocationClientMock.cpp View 1 2 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
sof
Please take a look. Noticed while looking at the flaky inspector/geolocation-emulation-tests.html crasher. (Might be the ...
6 years, 6 months ago (2014-06-16 07:19:10 UTC) #1
haraken
https://codereview.chromium.org/332153002/diff/1/Source/modules/geolocation/GeolocationInspectorAgent.h File Source/modules/geolocation/GeolocationInspectorAgent.h (right): https://codereview.chromium.org/332153002/diff/1/Source/modules/geolocation/GeolocationInspectorAgent.h#newcode65 Source/modules/geolocation/GeolocationInspectorAgent.h:65: Persistent<GeolocationControllers> m_controllers; Can we use PersistentHeapHashSet<Member<GeolocationController>> ? Then you ...
6 years, 6 months ago (2014-06-16 07:29:28 UTC) #2
sof
https://codereview.chromium.org/332153002/diff/1/Source/modules/geolocation/GeolocationInspectorAgent.h File Source/modules/geolocation/GeolocationInspectorAgent.h (right): https://codereview.chromium.org/332153002/diff/1/Source/modules/geolocation/GeolocationInspectorAgent.h#newcode65 Source/modules/geolocation/GeolocationInspectorAgent.h:65: Persistent<GeolocationControllers> m_controllers; On 2014/06/16 07:29:28, haraken wrote: > > ...
6 years, 6 months ago (2014-06-16 07:43:20 UTC) #3
haraken
LGTM
6 years, 6 months ago (2014-06-16 07:49:41 UTC) #4
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-16 08:06:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/332153002/20001
6 years, 6 months ago (2014-06-16 08:07:15 UTC) #6
sof
The CQ bit was unchecked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-16 08:19:49 UTC) #7
sof
Found another vulnerable hash set in geolocation/testing/ & fixed persistent hash set to contain transition ...
6 years, 6 months ago (2014-06-16 09:43:46 UTC) #8
Mads Ager (chromium)
LGTM
6 years, 6 months ago (2014-06-16 09:49:16 UTC) #9
zerny-chromium
lgtm https://codereview.chromium.org/332153002/diff/40001/Source/modules/geolocation/GeolocationInspectorAgent.h File Source/modules/geolocation/GeolocationInspectorAgent.h (right): https://codereview.chromium.org/332153002/diff/40001/Source/modules/geolocation/GeolocationInspectorAgent.h#newcode65 Source/modules/geolocation/GeolocationInspectorAgent.h:65: PersistentHeapHashSet<RawPtrWillBeMember<GeolocationController> > m_controllers; Should we use WillBe(Persistent)HeapHashSet for ...
6 years, 6 months ago (2014-06-16 09:50:18 UTC) #10
sof
https://codereview.chromium.org/332153002/diff/40001/Source/modules/geolocation/GeolocationInspectorAgent.h File Source/modules/geolocation/GeolocationInspectorAgent.h (right): https://codereview.chromium.org/332153002/diff/40001/Source/modules/geolocation/GeolocationInspectorAgent.h#newcode65 Source/modules/geolocation/GeolocationInspectorAgent.h:65: PersistentHeapHashSet<RawPtrWillBeMember<GeolocationController> > m_controllers; On 2014/06/16 09:50:18, zerny-chromium wrote: > ...
6 years, 6 months ago (2014-06-16 10:39:06 UTC) #11
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-16 10:59:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/332153002/60001
6 years, 6 months ago (2014-06-16 11:00:02 UTC) #13
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 12:03:17 UTC) #14
Message was sent while issue was closed. 
Change committed as 176202

Powered by Google App Engine
This is Rietveld 408576698