 Chromium Code Reviews
 Chromium Code Reviews Issue 332153002:
  Oilpan: have GeolocationInspectorAgent persistently track its controllers.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/blink.git@master
    
  
    Issue 332153002:
  Oilpan: have GeolocationInspectorAgent persistently track its controllers.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/blink.git@master| OLD | NEW | 
|---|---|
| 1 /* | 1 /* | 
| 2 * Copyright (C) 2014 Google Inc. All rights reserved. | 2 * Copyright (C) 2014 Google Inc. All rights reserved. | 
| 3 * | 3 * | 
| 4 * Redistribution and use in source and binary forms, with or without | 4 * Redistribution and use in source and binary forms, with or without | 
| 5 * modification, are permitted provided that the following conditions are | 5 * modification, are permitted provided that the following conditions are | 
| 6 * met: | 6 * met: | 
| 7 * | 7 * | 
| 8 * * Redistributions of source code must retain the above copyright | 8 * * Redistributions of source code must retain the above copyright | 
| 9 * notice, this list of conditions and the following disclaimer. | 9 * notice, this list of conditions and the following disclaimer. | 
| 10 * * Redistributions in binary form must reproduce the above | 10 * * Redistributions in binary form must reproduce the above | 
| (...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 54 virtual void clearGeolocationOverride(ErrorString*) OVERRIDE; | 54 virtual void clearGeolocationOverride(ErrorString*) OVERRIDE; | 
| 55 | 55 | 
| 56 // Instrumentation method. | 56 // Instrumentation method. | 
| 57 GeolocationPosition* overrideGeolocationPosition(GeolocationPosition*); | 57 GeolocationPosition* overrideGeolocationPosition(GeolocationPosition*); | 
| 58 | 58 | 
| 59 void AddController(GeolocationController*); | 59 void AddController(GeolocationController*); | 
| 60 void RemoveController(GeolocationController*); | 60 void RemoveController(GeolocationController*); | 
| 61 | 61 | 
| 62 private: | 62 private: | 
| 63 GeolocationInspectorAgent(); | 63 GeolocationInspectorAgent(); | 
| 64 WTF::HashSet<GeolocationController*> m_controllers; | 64 typedef HeapHashSet<Member<GeolocationController> > GeolocationControllers; | 
| 65 Persistent<GeolocationControllers> m_controllers; | |
| 
haraken
2014/06/16 07:29:28
Can we use PersistentHeapHashSet<Member<Geolocatio
 
sof
2014/06/16 07:43:20
Done.
 | |
| 65 bool m_geolocationOverridden; | 66 bool m_geolocationOverridden; | 
| 66 Persistent<GeolocationPosition> m_geolocationPosition; | 67 Persistent<GeolocationPosition> m_geolocationPosition; | 
| 67 Persistent<GeolocationPosition> m_platformGeolocationPosition; | 68 Persistent<GeolocationPosition> m_platformGeolocationPosition; | 
| 68 }; | 69 }; | 
| 69 | 70 | 
| 70 | 71 | 
| 71 } // namespace WebCore | 72 } // namespace WebCore | 
| 72 | 73 | 
| 73 | 74 | 
| 74 #endif // !defined(GeolocationInspectorAgent_h) | 75 #endif // !defined(GeolocationInspectorAgent_h) | 
| OLD | NEW |