Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: Source/modules/geolocation/testing/GeolocationClientMock.cpp

Issue 332153002: Oilpan: have GeolocationInspectorAgent persistently track its controllers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Make hash sets over controllers will-be-persistents Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/geolocation/testing/GeolocationClientMock.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/geolocation/testing/GeolocationClientMock.cpp
diff --git a/Source/modules/geolocation/testing/GeolocationClientMock.cpp b/Source/modules/geolocation/testing/GeolocationClientMock.cpp
index a3067e31d923e465891dfea4af4048dcc68b9b79..b82d2a94e820a524152862dfe3b348de996cf83a 100644
--- a/Source/modules/geolocation/testing/GeolocationClientMock.cpp
+++ b/Source/modules/geolocation/testing/GeolocationClientMock.cpp
@@ -167,13 +167,13 @@ void GeolocationClientMock::controllerTimerFired(Timer<GeolocationClientMock>* t
ASSERT_UNUSED(timer, timer == &m_controllerTimer);
// Make a copy of the set of controllers since it might be modified while iterating.
- HashSet<GeolocationController*> controllers = m_controllers;
+ GeolocationControllers controllers = m_controllers;
if (m_lastPosition.get()) {
ASSERT(!m_hasError);
- for (HashSet<GeolocationController*>::iterator it = controllers.begin(); it != controllers.end(); ++it)
+ for (GeolocationControllers::iterator it = controllers.begin(); it != controllers.end(); ++it)
(*it)->positionChanged(m_lastPosition.get());
} else if (m_hasError) {
- for (HashSet<GeolocationController*>::iterator it = controllers.begin(); it != controllers.end(); ++it)
+ for (GeolocationControllers::iterator it = controllers.begin(); it != controllers.end(); ++it)
(*it)->errorOccurred(GeolocationError::create(GeolocationError::PositionUnavailable, m_errorMessage));
}
}
« no previous file with comments | « Source/modules/geolocation/testing/GeolocationClientMock.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698