Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1876)

Unified Diff: Source/modules/geolocation/GeolocationInspectorAgent.cpp

Issue 332153002: Oilpan: have GeolocationInspectorAgent persistently track its controllers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Make hash sets over controllers will-be-persistents Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/geolocation/GeolocationInspectorAgent.cpp
diff --git a/Source/modules/geolocation/GeolocationInspectorAgent.cpp b/Source/modules/geolocation/GeolocationInspectorAgent.cpp
index aee328e59e988ddb4b2ccb61cf6b43fa27554a2f..049d821e010ad720106164fe36c24b45079e4892 100644
--- a/Source/modules/geolocation/GeolocationInspectorAgent.cpp
+++ b/Source/modules/geolocation/GeolocationInspectorAgent.cpp
@@ -62,7 +62,7 @@ void GeolocationInspectorAgent::setGeolocationOverride(ErrorString* error, const
else
m_geolocationPosition.clear();
- for (WTF::HashSet<GeolocationController*>::iterator it = m_controllers.begin(); it != m_controllers.end(); ++it)
+ for (GeolocationControllers::iterator it = m_controllers.begin(); it != m_controllers.end(); ++it)
(*it)->positionChanged(0); // Kick location update.
}
@@ -73,9 +73,9 @@ void GeolocationInspectorAgent::clearGeolocationOverride(ErrorString*)
m_geolocationOverridden = false;
m_geolocationPosition.clear();
- if (m_platformGeolocationPosition.get()) {
- for (WTF::HashSet<GeolocationController*>::iterator it = m_controllers.begin(); it != m_controllers.end(); ++it)
- (*it)->positionChanged(m_platformGeolocationPosition.get());
+ if (GeolocationPosition* platformPosition = m_platformGeolocationPosition.get()) {
+ for (GeolocationControllers::iterator it = m_controllers.begin(); it != m_controllers.end(); ++it)
+ (*it)->positionChanged(platformPosition);
}
}
« no previous file with comments | « Source/modules/geolocation/GeolocationInspectorAgent.h ('k') | Source/modules/geolocation/testing/GeolocationClientMock.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698