Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 331973002: Pepper: Move more UMA stuff out of trusted plugin. (Closed)

Created:
6 years, 6 months ago by teravest
Modified:
6 years, 6 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, raymes+watch_chromium.org, teravest+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, ihf+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Pepper: Move more UMA stuff out of trusted plugin. This is yet another pretty simple change just lifting more lines out of the trusted plugin. I added a method to PPB_NaCl_Private that's safe to call from a background thread (there are other methods that are safe as well) to keep the call sites simple. BUG=239656 R=dmichael@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277424

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : comment fix for dmichael #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -64 lines) Patch
M components/nacl/renderer/ppb_nacl_private_impl.cc View 2 chunks +11 lines, -1 line 0 comments Download
M ppapi/api/private/ppb_nacl_private.idl View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M ppapi/c/private/ppb_nacl_private.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h View 2 chunks +0 lines, -9 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc View 3 chunks +0 lines, -30 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc View 1 5 chunks +11 lines, -22 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
teravest
6 years, 6 months ago (2014-06-13 20:52:13 UTC) #1
dmichael (off chromium)
lgtm https://codereview.chromium.org/331973002/diff/20001/ppapi/api/private/ppb_nacl_private.idl File ppapi/api/private/ppb_nacl_private.idl (right): https://codereview.chromium.org/331973002/diff/20001/ppapi/api/private/ppb_nacl_private.idl#newcode440 ppapi/api/private/ppb_nacl_private.idl:440: * This function is safe to call off ...
6 years, 6 months ago (2014-06-13 21:10:35 UTC) #2
teravest
On Fri, Jun 13, 2014 at 3:10 PM, <dmichael@chromium.org> wrote: > lgtm > > > ...
6 years, 6 months ago (2014-06-13 21:16:02 UTC) #3
teravest
6 years, 6 months ago (2014-06-16 14:24:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r277424 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698