Pepper: Move more UMA stuff out of trusted plugin.

ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h"
 
 #include <utility>
 #include <vector>
 
 #include "native_client/src/include/checked_cast.h"
 #include "native_client/src/include/portability_io.h"
 #include "native_client/src/shared/platform/nacl_check.h"
 #include "native_client/src/trusted/service_runtime/include/sys/stat.h"
 
 #include "ppapi/c/pp_bool.h"
 #include "ppapi/c/pp_errors.h"
 #include "ppapi/c/private/ppb_uma_private.h"
 
 #include "ppapi/native_client/src/trusted/plugin/plugin.h"
 #include "ppapi/native_client/src/trusted/plugin/plugin_error.h"
 #include "ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.h"
 #include "ppapi/native_client/src/trusted/plugin/service_runtime.h"
 #include "ppapi/native_client/src/trusted/plugin/temporary_file.h"
 
 namespace plugin {
 
 namespace {
 
-// Assume translation time metrics *can be* large.
-// Up to 12 minutes.
-const int64_t kTimeLargeMin = 10;          // in ms
-const int64_t kTimeLargeMax = 720000;      // in ms
-const uint32_t kTimeLargeBuckets = 100;
-
 const int32_t kSizeKBMin = 1;
 const int32_t kSizeKBMax = 512*1024;       // very large .pexe / .nexe.
 const uint32_t kSizeKBBuckets = 100;
 
 const int32_t kRatioMin = 10;
 const int32_t kRatioMax = 10*100;          // max of 10x difference.
 const uint32_t kRatioBuckets = 100;
 
-void HistogramTime(pp::UMAPrivate& uma,
-                   const nacl::string& name, int64_t ms) {
-  if (ms < 0) return;
-  uma.HistogramCustomTimes(name,
-                           ms,
-                           kTimeLargeMin, kTimeLargeMax,
-                           kTimeLargeBuckets);
-}
-
 void HistogramSizeKB(pp::UMAPrivate& uma,
                      const nacl::string& name, int32_t kb) {
   if (kb < 0) return;
   uma.HistogramCustomCounts(name,
                             kb,
                             kSizeKBMin, kSizeKBMax,
                             kSizeKBBuckets);
 }
 
 void HistogramRatio(pp::UMAPrivate& uma,
@@ skipping 461 matching lines @@
                                       expected_pexe_size_);
   }
 }
 
 pp::CompletionCallback PnaclCoordinator::GetCompileProgressCallback(
     int64_t bytes_compiled) {
   return callback_factory_.NewCallback(&PnaclCoordinator::BitcodeGotCompiled,
                                        bytes_compiled);
 }
 
-void PnaclCoordinator::DoUMATimeMeasure(int32_t pp_error,
-                                        const nacl::string& event_name,
-                                        int64_t microsecs) {
-  DCHECK(pp_error == PP_OK);
-  HistogramTime(
-      plugin_->uma_interface(), event_name, microsecs / NACL_MICROS_PER_MILLI);
-}
-
-pp::CompletionCallback PnaclCoordinator::GetUMATimeCallback(
-    const nacl::string& event_name, int64_t microsecs) {
-  return callback_factory_.NewCallback(&PnaclCoordinator::DoUMATimeMeasure,
-                                       event_name,
-                                       microsecs);
-}
-
 void PnaclCoordinator::GetCurrentProgress(int64_t* bytes_loaded,
                                           int64_t* bytes_total) {
   *bytes_loaded = pexe_bytes_compiled_;
   *bytes_total = expected_pexe_size_;
 }
 
 void PnaclCoordinator::RunTranslate(int32_t pp_error) {
   PLUGIN_PRINTF(("PnaclCoordinator::RunTranslate (pp_error=%"
                  NACL_PRId32 ")\n", pp_error));
   // Invoke llc followed by ld off the main thread.  This allows use of
   // blocking RPCs that would otherwise block the JavaScript main thread.
   pp::CompletionCallback report_translate_finished =
       callback_factory_.NewCallback(&PnaclCoordinator::TranslateFinished);
 
   CHECK(translate_thread_ != NULL);
   translate_thread_->RunTranslate(report_translate_finished,
                                   &obj_files_,
                                   temp_nexe_file_.get(),
                                   invalid_desc_wrapper_.get(),
                                   &error_info_,
                                   resources_.get(),
                                   &pnacl_options_,
                                   architecture_attributes_,
                                   this,
                                   plugin_);
 }
 
 }  // namespace plugin