Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Unified Diff: ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc

Issue 331973002: Pepper: Move more UMA stuff out of trusted plugin. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comment fix for dmichael Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc
diff --git a/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc b/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc
index f2b00af3e4604eff12d065a563e92577782abb35..5f3c4f0d35b2b2b7cac368f9a2d34ca9583bf1fd 100644
--- a/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc
+++ b/ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc
@@ -174,11 +174,9 @@ void PnaclTranslateThread::DoTranslate() {
error_info.message());
return;
}
- core->CallOnMainThread(0,
- coordinator_->GetUMATimeCallback(
- "NaCl.Perf.PNaClLoadTime.LoadCompiler",
- NaClGetTimeOfDayMicroseconds() - llc_start_time),
- PP_OK);
+ GetNaClInterface()->LogTranslateTime(
+ "NaCl.Perf.PNaClLoadTime.LoadCompiler",
+ NaClGetTimeOfDayMicroseconds() - llc_start_time);
{
nacl::MutexLocker ml(&subprocess_mu_);
@@ -301,11 +299,8 @@ void PnaclTranslateThread::DoTranslate() {
return;
}
compile_time_ = NaClGetTimeOfDayMicroseconds() - compile_start_time;
- core->CallOnMainThread(0,
- coordinator_->GetUMATimeCallback(
- "NaCl.Perf.PNaClLoadTime.CompileTime",
- compile_time_),
- PP_OK);
+ GetNaClInterface()->LogTranslateTime("NaCl.Perf.PNaClLoadTime.CompileTime",
+ compile_time_);
// Shut down the llc subprocess.
NaClXMutexLock(&subprocess_mu_);
@@ -338,7 +333,6 @@ bool PnaclTranslateThread::RunLdSubprocess() {
ld_in_files.push_back(invalid_desc_wrapper_);
nacl::DescWrapper* ld_out_file = nexe_file_->write_wrapper();
- pp::Core* core = pp::Module::Get()->core();
int64_t ld_start_time = NaClGetTimeOfDayMicroseconds();
PP_FileHandle ld_file_handle = resources_->TakeLdFileHandle();
// On success, ownership of ld_file_handle is transferred.
@@ -354,12 +348,9 @@ bool PnaclTranslateThread::RunLdSubprocess() {
error_info.message());
return false;
}
- core->CallOnMainThread(0,
- coordinator_->GetUMATimeCallback(
- "NaCl.Perf.PNaClLoadTime.LoadLinker",
- NaClGetTimeOfDayMicroseconds() - ld_start_time),
- PP_OK);
-
+ GetNaClInterface()->LogTranslateTime(
+ "NaCl.Perf.PNaClLoadTime.LoadLinker",
+ NaClGetTimeOfDayMicroseconds() - ld_start_time);
{
nacl::MutexLocker ml(&subprocess_mu_);
// If we received a call to AbortSubprocesses() before we had a chance to
@@ -402,11 +393,9 @@ bool PnaclTranslateThread::RunLdSubprocess() {
"link failed.");
return false;
}
- core->CallOnMainThread(0,
- coordinator_->GetUMATimeCallback(
- "NaCl.Perf.PNaClLoadTime.LinkTime",
- NaClGetTimeOfDayMicroseconds() - link_start_time),
- PP_OK);
+ GetNaClInterface()->LogTranslateTime(
+ "NaCl.Perf.PNaClLoadTime.LinkTime",
+ NaClGetTimeOfDayMicroseconds() - link_start_time);
PLUGIN_PRINTF(("PnaclCoordinator: link (translator=%p) succeeded\n",
this));
// Shut down the ld subprocess.

Powered by Google App Engine
This is Rietveld 408576698