Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc

Issue 331973002: Pepper: Move more UMA stuff out of trusted plugin. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comment fix for dmichael Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc
diff --git a/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc b/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc
index bd3d1c1682cc5e5f7ff23b4c85a12015d7d173f1..c0a9b3ec0d9f69d362407b14defc30ed77403923 100644
--- a/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc
+++ b/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc
@@ -26,12 +26,6 @@ namespace plugin {
namespace {
-// Assume translation time metrics *can be* large.
-// Up to 12 minutes.
-const int64_t kTimeLargeMin = 10; // in ms
-const int64_t kTimeLargeMax = 720000; // in ms
-const uint32_t kTimeLargeBuckets = 100;
-
const int32_t kSizeKBMin = 1;
const int32_t kSizeKBMax = 512*1024; // very large .pexe / .nexe.
const uint32_t kSizeKBBuckets = 100;
@@ -40,15 +34,6 @@ const int32_t kRatioMin = 10;
const int32_t kRatioMax = 10*100; // max of 10x difference.
const uint32_t kRatioBuckets = 100;
-void HistogramTime(pp::UMAPrivate& uma,
- const nacl::string& name, int64_t ms) {
- if (ms < 0) return;
- uma.HistogramCustomTimes(name,
- ms,
- kTimeLargeMin, kTimeLargeMax,
- kTimeLargeBuckets);
-}
-
void HistogramSizeKB(pp::UMAPrivate& uma,
const nacl::string& name, int32_t kb) {
if (kb < 0) return;
@@ -530,21 +515,6 @@ pp::CompletionCallback PnaclCoordinator::GetCompileProgressCallback(
bytes_compiled);
}
-void PnaclCoordinator::DoUMATimeMeasure(int32_t pp_error,
- const nacl::string& event_name,
- int64_t microsecs) {
- DCHECK(pp_error == PP_OK);
- HistogramTime(
- plugin_->uma_interface(), event_name, microsecs / NACL_MICROS_PER_MILLI);
-}
-
-pp::CompletionCallback PnaclCoordinator::GetUMATimeCallback(
- const nacl::string& event_name, int64_t microsecs) {
- return callback_factory_.NewCallback(&PnaclCoordinator::DoUMATimeMeasure,
- event_name,
- microsecs);
-}
-
void PnaclCoordinator::GetCurrentProgress(int64_t* bytes_loaded,
int64_t* bytes_total) {
*bytes_loaded = pexe_bytes_compiled_;

Powered by Google App Engine
This is Rietveld 408576698