Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 329793003: Don't draw a window title on browser windows. (Closed)

Created:
6 years, 6 months ago by Avi (use Gerrit)
Modified:
6 years, 6 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Don't draw a window title on browser windows. BUG=380229 TEST=as in bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276855

Patch Set 1 #

Total comments: 2

Patch Set 2 : new #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -13 lines) Patch
M base/mac/sdk_forward_declarations.h View 1 chunk +19 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm View 1 chunk +20 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/framed_browser_window.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/framed_browser_window.mm View 1 3 chunks +16 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/framed_browser_window_unittest.mm View 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Avi (use Gerrit)
6 years, 6 months ago (2014-06-12 17:55:15 UTC) #1
Mark Mentovai
LGTM https://codereview.chromium.org/329793003/diff/1/chrome/browser/ui/cocoa/framed_browser_window.mm File chrome/browser/ui/cocoa/framed_browser_window.mm (right): https://codereview.chromium.org/329793003/diff/1/chrome/browser/ui/cocoa/framed_browser_window.mm#newcode364 chrome/browser/ui/cocoa/framed_browser_window.mm:364: if (base::mac::IsOSMavericksOrEarlier() && Ask if the window doesn’t ...
6 years, 6 months ago (2014-06-12 18:27:14 UTC) #2
Avi (use Gerrit)
https://codereview.chromium.org/329793003/diff/1/chrome/browser/ui/cocoa/framed_browser_window.mm File chrome/browser/ui/cocoa/framed_browser_window.mm (right): https://codereview.chromium.org/329793003/diff/1/chrome/browser/ui/cocoa/framed_browser_window.mm#newcode364 chrome/browser/ui/cocoa/framed_browser_window.mm:364: if (base::mac::IsOSMavericksOrEarlier() && On 2014/06/12 18:27:14, Mark Mentovai wrote: ...
6 years, 6 months ago (2014-06-12 18:30:31 UTC) #3
Mark Mentovai
I don’t see a fresh upload but it’s still LGTM.
6 years, 6 months ago (2014-06-12 18:33:04 UTC) #4
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 6 months ago (2014-06-12 18:34:30 UTC) #5
Mark Mentovai
LGTM for real now.
6 years, 6 months ago (2014-06-12 18:38:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/329793003/20001
6 years, 6 months ago (2014-06-12 18:40:41 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 23:52:21 UTC) #8
Message was sent while issue was closed. 
Change committed as 276855

Powered by Google App Engine
This is Rietveld 408576698