Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 329793003: Don't draw a window title on browser windows. (Closed)

Created:
3 years, 7 months ago by Avi (use Gerrit)
Modified:
3 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Don't draw a window title on browser windows. BUG=380229 TEST=as in bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276855

Patch Set 1 #

Total comments: 2

Patch Set 2 : new #

Messages

Total messages: 8 (0 generated)
Avi (use Gerrit)
3 years, 7 months ago (2014-06-12 17:55:15 UTC) #1
Mark Mentovai
LGTM https://codereview.chromium.org/329793003/diff/1/chrome/browser/ui/cocoa/framed_browser_window.mm File chrome/browser/ui/cocoa/framed_browser_window.mm (right): https://codereview.chromium.org/329793003/diff/1/chrome/browser/ui/cocoa/framed_browser_window.mm#newcode364 chrome/browser/ui/cocoa/framed_browser_window.mm:364: if (base::mac::IsOSMavericksOrEarlier() && Ask if the window doesn’t ...
3 years, 7 months ago (2014-06-12 18:27:14 UTC) #2
Avi (use Gerrit)
https://codereview.chromium.org/329793003/diff/1/chrome/browser/ui/cocoa/framed_browser_window.mm File chrome/browser/ui/cocoa/framed_browser_window.mm (right): https://codereview.chromium.org/329793003/diff/1/chrome/browser/ui/cocoa/framed_browser_window.mm#newcode364 chrome/browser/ui/cocoa/framed_browser_window.mm:364: if (base::mac::IsOSMavericksOrEarlier() && On 2014/06/12 18:27:14, Mark Mentovai wrote: ...
3 years, 7 months ago (2014-06-12 18:30:31 UTC) #3
Mark Mentovai
I don’t see a fresh upload but it’s still LGTM.
3 years, 7 months ago (2014-06-12 18:33:04 UTC) #4
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
3 years, 7 months ago (2014-06-12 18:34:30 UTC) #5
Mark Mentovai
LGTM for real now.
3 years, 7 months ago (2014-06-12 18:38:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/329793003/20001
3 years, 7 months ago (2014-06-12 18:40:41 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2014-06-12 23:52:21 UTC) #8
Message was sent while issue was closed.
Change committed as 276855

Powered by Google App Engine
This is Rietveld 0eb02b776