Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: chrome/browser/ui/cocoa/framed_browser_window_unittest.mm

Issue 329793003: Don't draw a window title on browser windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/framed_browser_window.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/framed_browser_window_unittest.mm
diff --git a/chrome/browser/ui/cocoa/framed_browser_window_unittest.mm b/chrome/browser/ui/cocoa/framed_browser_window_unittest.mm
index 32322eec913e1b07e995026e5bf8bdd2cfc23139..9931a679de5f85f7447329ccf32427215edf519f 100644
--- a/chrome/browser/ui/cocoa/framed_browser_window_unittest.mm
+++ b/chrome/browser/ui/cocoa/framed_browser_window_unittest.mm
@@ -5,6 +5,7 @@
#import <Cocoa/Cocoa.h>
#include "base/debug/debugger.h"
+#include "base/mac/mac_util.h"
#include "base/mac/scoped_nsobject.h"
#include "chrome/app/chrome_command_ids.h"
#import "chrome/browser/ui/cocoa/browser_window_controller.h"
@@ -70,7 +71,7 @@ TEST_F(FramedBrowserWindowTest, ShowAndClose) {
[window_ display];
}
-// Test that undocumented title-hiding API we're using does the job.
+// Test that the title-hiding API we're using does the job.
TEST_F(FramedBrowserWindowTest, DoesHideTitle) {
// The -display calls are not strictly necessary, but they do
// make it easier to see what's happening when debugging (without
@@ -97,8 +98,11 @@ TEST_F(FramedBrowserWindowTest, DoesHideTitle) {
// With our magic setting, the window with a title should look the
// same as the window with an empty title.
- EXPECT_TRUE([window_ _isTitleHidden]);
EXPECT_TRUE([emptyTitleData isEqualToData:hiddenTitleData]);
+
+ // Test the secret API only on versions of the system in which it exists.
+ if (base::mac::IsOSMavericksOrEarlier())
+ EXPECT_TRUE([window_ _isTitleHidden]);
}
// Test to make sure that our window widgets are in the right place.
« no previous file with comments | « chrome/browser/ui/cocoa/framed_browser_window.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698