Don't draw a window title on browser windows.

chrome/browser/ui/cocoa/framed_browser_window.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/framed_browser_window.h"
 
 #include "base/logging.h"
+#include "base/mac/mac_util.h"
 #include "base/mac/sdk_forward_declarations.h"
 #include "chrome/browser/global_keyboard_shortcuts_mac.h"
 #include "chrome/browser/profiles/profile_avatar_icon_util.h"
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
 #import "chrome/browser/ui/cocoa/browser_window_utils.h"
 #import "chrome/browser/ui/cocoa/custom_frame_view.h"
 #import "chrome/browser/ui/cocoa/nsview_additions.h"
 #import "chrome/browser/ui/cocoa/tabs/tab_strip_controller.h"
 #import "chrome/browser/ui/cocoa/themed_window.h"
 #include "chrome/browser/themes/theme_properties.h"
@@ skipping 11 matching lines @@
 namespace {
 
 const CGFloat kBrowserFrameViewPaintHeight = 60.0;
 
 // Size of the gradient. Empirically determined so that the gradient looks
 // like what the heuristic does when there are just a few tabs.
 const CGFloat kWindowGradientHeight = 24.0;
 
 }
 
-@interface FramedBrowserWindow (Private)
+@interface FramedBrowserWindow ()
 
 - (void)adjustCloseButton:(NSNotification*)notification;
 - (void)adjustMiniaturizeButton:(NSNotification*)notification;
 - (void)adjustZoomButton:(NSNotification*)notification;
 - (void)adjustButton:(NSButton*)button
               ofKind:(NSWindowButton)kind;
 - (NSView*)frameView;
 
 @end
 
@@ skipping 195 matching lines @@
         eventHandled = YES;
       }
     }
   }
   if (!eventHandled) {
     [super sendEvent:event];
   }
 }
 
 - (void)setShouldHideTitle:(BOOL)flag {
-  shouldHideTitle_ = flag;
+  if ([self respondsToSelector:@selector(setTitleVisibility:)])
+    self.titleVisibility = flag ? NSWindowTitleHidden : NSWindowTitleVisible;
+  else
+    shouldHideTitle_ = flag;
 }
 
 - (BOOL)_isTitleHidden {
-  return shouldHideTitle_;
+  // Only intervene with 10.6-10.9.
+  if ([self respondsToSelector:@selector(setTitleVisibility:)])
+    return [super _isTitleHidden];
+  else
+    return shouldHideTitle_;
 }
 
 - (CGFloat)windowButtonsInterButtonSpacing {
   return windowButtonsInterButtonSpacing_;
 }
 
 // This method is called whenever a window is moved in order to ensure it fits
 // on the screen.  We cannot always handle resizes without breaking, so we
 // prevent frame constraining in those cases.
 - (NSRect)constrainFrameRect:(NSRect)frame toScreen:(NSScreen*)screen {
@@ skipping 72 matching lines @@
                                    yRadius:cornerRadius] addClip];
   [[NSBezierPath bezierPathWithRect:rect] addClip];
 
   // Do the theming.
   BOOL themed = [FramedBrowserWindow
       drawWindowThemeInDirtyRect:rect
                          forView:view
                           bounds:windowRect
             forceBlackBackground:NO];
 
-  // If the window needs a title and we painted over the title as drawn by the
-  // default window paint, paint it ourselves.
-  if (themed && [view respondsToSelector:@selector(_titlebarTitleRect)] &&
+  // In Yosemite: The title is drawn by a subview and not painted on. Therefore,
+  // never worry about drawing it. Pre-Yosemite: If the window needs a title and
+  // we painted over the title as drawn by the default window paint, paint it
+  // ourselves.
+  if (base::mac::IsOSMavericksOrEarlier() &&

[Mark Mentovai, 2014/06/12 18:27:14]

Ask if the window doesn’t respond to the selector instead of testing the OS? (If
you do this, you can drop the mac_util.h #include.)

[Avi (use Gerrit), 2014/06/12 18:30:31]

Done.

+      themed && [view respondsToSelector:@selector(_titlebarTitleRect)] &&
       [view respondsToSelector:@selector(_drawTitleStringIn:withColor:)] &&
       ![self _isTitleHidden]) {
     [view _drawTitleStringIn:[view _titlebarTitleRect]
                    withColor:[self titleColor]];
   }
 
   // Pinstripe the top.
   if (themed) {
     CGFloat lineWidth = [view cr_lineWidth];
 
@@ skipping 122 matching lines @@
   ThemedWindowStyle windowStyle = [self themedWindowStyle];
   BOOL incognito = windowStyle & THEMED_INCOGNITO;
 
   if (incognito)
     return [NSColor whiteColor];
   else
     return [NSColor windowFrameTextColor];
 }
 
 @end