Removing "using" declarations that import names in the C++ Standard library.

Removing "using" declarations that import names in the C++ Standard library.

This is as per the the coding guidelines for blink, which disallows the
use of "using" declarations of any kind to import names in the standard
template library.

BUG=NONE

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176032

[Sunil Ratnu, 2014-06-11 15:27:41]

Please have a look.

[Sunil Ratnu, 2014-06-11 16:26:53]

On 2014/06/11 15:27:41, sunilratnu wrote:
> Please have a look.

There seems to be a rebase problem with my patch. Will resolve it tomorrow to
keep trybots passing.

[tkent, 2014-06-12 00:23:24]

> Removing "using" declarations that import names in the STL library

"STL library" is not the correct name.  We should call it like "C++ standard
library."

https://codereview.chromium.org/329183002/diff/1/Source/core/animation/Animat...
File Source/core/animation/AnimationTranslationUtil.cpp (right):

https://codereview.chromium.org/329183002/diff/1/Source/core/animation/Animat...
Source/core/animation/AnimationTranslationUtil.cpp:50: for (std::size_t j = 0; j
< transformOperations.size(); ++j) {
Do we really need std:: for size_t?

[Sunil Ratnu, 2014-06-12 09:00:02]

Thanks tkent for the quick review!
Made the changes suggested by you. Please have a look.

https://codereview.chromium.org/329183002/diff/1/Source/core/animation/Animat...
File Source/core/animation/AnimationTranslationUtil.cpp (right):

https://codereview.chromium.org/329183002/diff/1/Source/core/animation/Animat...
Source/core/animation/AnimationTranslationUtil.cpp:50: for (std::size_t j = 0; j
< transformOperations.size(); ++j) {
On 2014/06/12 00:23:23, tkent wrote:
> Do we really need std:: for size_t?

Thanks tkent. They are not needed as ::size_t is defined in the backward
compatibility header stddef.h and every C++ implementation ships with it for
compatability.

[tkent, 2014-06-12 09:06:20]

lgtm

[haraken, 2014-06-12 09:19:24]

LGTM for bindings/.

[Sunil Ratnu, 2014-06-12 09:29:24]

The CQ bit was checked by sunil.ratnu@samsung.com

[commit-bot: I haz the power, 2014-06-12 09:30:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/329183002/20001

[Sunil Ratnu, 2014-06-12 09:30:16]

The CQ bit was unchecked by sunil.ratnu@samsung.com

[Sunil Ratnu, 2014-06-12 14:23:10]

The CQ bit was checked by sunil.ratnu@samsung.com

[commit-bot: I haz the power, 2014-06-12 14:24:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/329183002/40001

[commit-bot: I haz the power, 2014-06-12 16:01:32]

Change committed as 176032

[Stephen Chennney, 2014-06-13 19:17:49]

A revert of this CL has been created in
https://codereview.chromium.org/330933002/ by schenney@chromium.org.

The reason for reverting is: This patch is causing failures on the Chromium
Linux Tsan v2 bot:
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Builder%20(T...

The problem is that std::abs(int) is found in <cstdlib> but we apparently only
include <cmath> everywhere. So the compiler only knows about std::abs(float) and
variants.

You can probably fix this by including <cstdlib> in the places where you use
std::abs..