Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 330933002: Revert of Removing "using" declarations that import names in the C++ Standard library. (Closed)

Created:
6 years, 6 months ago by Stephen Chennney
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, shans, tzik, eae+blinkwatch, fs, yurys+blink_chromium.org, apavlov+blink_chromium.org, loislo+blink_chromium.org, Steve Block, rwlbuis, krit, caseq+blink_chromium.org, aandrey+blink_chromium.org, arv+blink, Mike Lawther (Google), malch+blink_chromium.org, Timothy Loh, abarth-chromium, dstockwell, dglazkov+blink, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, pdr., Eric Willigers, rjwright, sof, nhiroki, eustas+blink_chromium.org, paulirish+reviews_chromium.org, lushnikov+blink_chromium.org, darktears, Stephen Chennney, blink-reviews-animation_chromium.org, kouhei+svg_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, ed+blinkwatch_opera.com, f(malita), groby+blinkspell_chromium.org, sergeyv+blink_chromium.org, kinuko+fileapi, gyuyoung.kim_webkit.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert of Removing "using" declarations that import names in the C++ Standard library. (https://codereview.chromium.org/329183002/) Reason for revert: This patch is causing failures on the Chromium Linux Tsan v2 bot: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Builder%20(TSan%20v2) The problem is that std::abs(int) is found in <cstdlib> but we apparently only include <cmath> everywhere. So the compiler only knows about std::abs(float) and variants. You can probably fix this by including <cstdlib> in the places where you use std::abs. Original issue's description: > Removing "using" declarations that import names in the C++ Standard library. > > This is as per the the coding guidelines for blink, which disallows the > use of "using" declarations of any kind to import names in the standard > template library. > > BUG=NONE > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176032 TBR=tkent@chromium.org,ch.dumez@samsung.com,sunil.ratnu@samsung.com NOTREECHECKS=true NOTRY=true BUG=NONE Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176125

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -81 lines) Patch
M Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/bindings/v8/custom/V8GeolocationCustom.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/animation/AnimationTranslationUtil.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Node.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/dom/Range.cpp View 4 chunks +5 lines, -4 lines 0 comments Download
M Source/core/dom/Text.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/ViewportDescription.cpp View 4 chunks +11 lines, -9 lines 0 comments Download
M Source/core/editing/CompositeEditCommand.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/editing/Editor.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M Source/core/editing/TextIterator.cpp View 9 chunks +11 lines, -10 lines 0 comments Download
M Source/core/editing/htmlediting.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/editing/markup.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/fileapi/FileReaderLoader.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/frame/DOMTimer.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/frame/ImageBitmap.cpp View 7 chunks +13 lines, -11 lines 0 comments Download
M Source/core/frame/LocalFrame.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/inspector/ContentSearchUtils.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/inspector/DOMEditor.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/inspector/DOMPatchSupport.cpp View 5 chunks +9 lines, -7 lines 0 comments Download
M Source/core/inspector/InjectedScriptHost.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/page/ScopedPageLoadDeferrer.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/page/TouchDisambiguation.cpp View 4 chunks +6 lines, -4 lines 0 comments Download
M Source/core/svg/animation/SMILTimeContainer.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/svg/animation/SVGSMILElement.cpp View 8 chunks +11 lines, -9 lines 0 comments Download
M Source/core/xml/XMLTreeViewer.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/xml/parser/XMLDocumentParser.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebPagePopupImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebPluginScrollbarImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 7 chunks +11 lines, -10 lines 0 comments Download
M Source/web/tests/ScrollAnimatorNoneTest.cpp View 3 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Stephen Chennney
Created Revert of Removing "using" declarations that import names in the C++ Standard library.
6 years, 6 months ago (2014-06-13 19:17:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/schenney@chromium.org/330933002/1
6 years, 6 months ago (2014-06-13 19:19:05 UTC) #2
commit-bot: I haz the power
Change committed as 176125
6 years, 6 months ago (2014-06-13 19:19:52 UTC) #3
Lei Zhang
On 2014/06/13 19:17:50, Stephen Chenney wrote: > Created Revert of Removing "using" declarations that import ...
6 years, 6 months ago (2014-06-14 00:28:01 UTC) #4
haraken
6 years, 6 months ago (2014-06-14 00:31:51 UTC) #5
Message was sent while issue was closed.
On 2014/06/14 00:28:01, Lei Zhang wrote:
> On 2014/06/13 19:17:50, Stephen Chenney wrote:
> > Created Revert of Removing "using" declarations that import names in the C++
> > Standard library.
> 
> Thanks for the revert, though I did try to fix it...
> https://codereview.chromium.org/338603003/

LGTM to the revert. Let's reland it once Lei's fix is in.

Powered by Google App Engine
This is Rietveld 408576698