Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Side by Side Diff: Source/web/WebPagePopupImpl.cpp

Issue 329183002: Removing "using" declarations that import names in the C++ Standard library. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed Trybot Errors Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/web/WebDevToolsAgentImpl.cpp ('k') | Source/web/WebPluginScrollbarImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 #include "core/page/PagePopupClient.h" 45 #include "core/page/PagePopupClient.h"
46 #include "platform/TraceEvent.h" 46 #include "platform/TraceEvent.h"
47 #include "public/platform/WebCursorInfo.h" 47 #include "public/platform/WebCursorInfo.h"
48 #include "public/web/WebViewClient.h" 48 #include "public/web/WebViewClient.h"
49 #include "public/web/WebWidgetClient.h" 49 #include "public/web/WebWidgetClient.h"
50 #include "web/WebInputEventConversion.h" 50 #include "web/WebInputEventConversion.h"
51 #include "web/WebSettingsImpl.h" 51 #include "web/WebSettingsImpl.h"
52 #include "web/WebViewImpl.h" 52 #include "web/WebViewImpl.h"
53 53
54 using namespace WebCore; 54 using namespace WebCore;
55 using namespace std;
56 55
57 namespace blink { 56 namespace blink {
58 57
59 class PagePopupChromeClient : public EmptyChromeClient { 58 class PagePopupChromeClient : public EmptyChromeClient {
60 WTF_MAKE_NONCOPYABLE(PagePopupChromeClient); 59 WTF_MAKE_NONCOPYABLE(PagePopupChromeClient);
61 WTF_MAKE_FAST_ALLOCATED; 60 WTF_MAKE_FAST_ALLOCATED;
62 61
63 public: 62 public:
64 explicit PagePopupChromeClient(WebPagePopupImpl* popup) 63 explicit PagePopupChromeClient(WebPagePopupImpl* popup)
65 : m_popup(popup) 64 : m_popup(popup)
(...skipping 337 matching lines...) Expand 10 before | Expand all | Expand 10 after
403 // A WebPagePopupImpl instance usually has two references. 402 // A WebPagePopupImpl instance usually has two references.
404 // - One owned by the instance itself. It represents the visible widget. 403 // - One owned by the instance itself. It represents the visible widget.
405 // - One owned by a WebViewImpl. It's released when the WebViewImpl ask the 404 // - One owned by a WebViewImpl. It's released when the WebViewImpl ask the
406 // WebPagePopupImpl to close. 405 // WebPagePopupImpl to close.
407 // We need them because the closing operation is asynchronous and the widget 406 // We need them because the closing operation is asynchronous and the widget
408 // can be closed while the WebViewImpl is unaware of it. 407 // can be closed while the WebViewImpl is unaware of it.
409 return adoptRef(new WebPagePopupImpl(client)).leakRef(); 408 return adoptRef(new WebPagePopupImpl(client)).leakRef();
410 } 409 }
411 410
412 } // namespace blink 411 } // namespace blink
OLDNEW
« no previous file with comments | « Source/web/WebDevToolsAgentImpl.cpp ('k') | Source/web/WebPluginScrollbarImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698