Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Side by Side Diff: Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp

Issue 329183002: Removing "using" declarations that import names in the C++ Standard library. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed Trybot Errors Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/bindings/v8/custom/V8GeolocationCustom.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007-2011 Google Inc. All rights reserved. 2 * Copyright (C) 2007-2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 #include "core/events/EventTarget.h" 42 #include "core/events/EventTarget.h"
43 #include "wtf/ASCIICType.h" 43 #include "wtf/ASCIICType.h"
44 #include "wtf/PassRefPtr.h" 44 #include "wtf/PassRefPtr.h"
45 #include "wtf/RefPtr.h" 45 #include "wtf/RefPtr.h"
46 #include "wtf/StdLibExtras.h" 46 #include "wtf/StdLibExtras.h"
47 #include "wtf/Vector.h" 47 #include "wtf/Vector.h"
48 #include "wtf/text/StringBuilder.h" 48 #include "wtf/text/StringBuilder.h"
49 #include "wtf/text/StringConcatenate.h" 49 #include "wtf/text/StringConcatenate.h"
50 50
51 using namespace WTF; 51 using namespace WTF;
52 using namespace std;
53 52
54 namespace WebCore { 53 namespace WebCore {
55 54
56 // Check for a CSS prefix. 55 // Check for a CSS prefix.
57 // Passed prefix is all lowercase. 56 // Passed prefix is all lowercase.
58 // First character of the prefix within the property name may be upper or lowerc ase. 57 // First character of the prefix within the property name may be upper or lowerc ase.
59 // Other characters in the prefix within the property name must be lowercase. 58 // Other characters in the prefix within the property name must be lowercase.
60 // The prefix within the property name must be followed by a capital letter. 59 // The prefix within the property name must be followed by a capital letter.
61 static bool hasCSSPropertyNamePrefix(const String& propertyName, const char* pre fix) 60 static bool hasCSSPropertyNamePrefix(const String& propertyName, const char* pre fix)
62 { 61 {
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 typedef Vector<String, numCSSProperties - 1> PreAllocatedPropertyVector; 157 typedef Vector<String, numCSSProperties - 1> PreAllocatedPropertyVector;
159 DEFINE_STATIC_LOCAL(PreAllocatedPropertyVector, propertyNames, ()); 158 DEFINE_STATIC_LOCAL(PreAllocatedPropertyVector, propertyNames, ());
160 static unsigned propertyNamesLength = 0; 159 static unsigned propertyNamesLength = 0;
161 160
162 if (propertyNames.isEmpty()) { 161 if (propertyNames.isEmpty()) {
163 for (int id = firstCSSProperty; id <= lastCSSProperty; ++id) { 162 for (int id = firstCSSProperty; id <= lastCSSProperty; ++id) {
164 CSSPropertyID propertyId = static_cast<CSSPropertyID>(id); 163 CSSPropertyID propertyId = static_cast<CSSPropertyID>(id);
165 if (RuntimeCSSEnabled::isCSSPropertyEnabled(propertyId)) 164 if (RuntimeCSSEnabled::isCSSPropertyEnabled(propertyId))
166 propertyNames.append(getJSPropertyName(propertyId)); 165 propertyNames.append(getJSPropertyName(propertyId));
167 } 166 }
168 sort(propertyNames.begin(), propertyNames.end(), codePointCompareLessTha n); 167 std::sort(propertyNames.begin(), propertyNames.end(), codePointCompareLe ssThan);
169 propertyNamesLength = propertyNames.size(); 168 propertyNamesLength = propertyNames.size();
170 } 169 }
171 170
172 v8::Handle<v8::Array> properties = v8::Array::New(info.GetIsolate(), propert yNamesLength); 171 v8::Handle<v8::Array> properties = v8::Array::New(info.GetIsolate(), propert yNamesLength);
173 for (unsigned i = 0; i < propertyNamesLength; ++i) { 172 for (unsigned i = 0; i < propertyNamesLength; ++i) {
174 String key = propertyNames.at(i); 173 String key = propertyNames.at(i);
175 ASSERT(!key.isNull()); 174 ASSERT(!key.isNull());
176 properties->Set(v8::Integer::New(info.GetIsolate(), i), v8String(info.Ge tIsolate(), key)); 175 properties->Set(v8::Integer::New(info.GetIsolate(), i), v8String(info.Ge tIsolate(), key));
177 } 176 }
178 177
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
224 ExceptionState exceptionState(ExceptionState::SetterContext, getPropertyName (static_cast<CSSPropertyID>(propInfo->propID)), "CSSStyleDeclaration", info.Hold er(), info.GetIsolate()); 223 ExceptionState exceptionState(ExceptionState::SetterContext, getPropertyName (static_cast<CSSPropertyID>(propInfo->propID)), "CSSStyleDeclaration", info.Hold er(), info.GetIsolate());
225 impl->setPropertyInternal(static_cast<CSSPropertyID>(propInfo->propID), prop ertyValue, false, exceptionState); 224 impl->setPropertyInternal(static_cast<CSSPropertyID>(propInfo->propID), prop ertyValue, false, exceptionState);
226 225
227 if (exceptionState.throwIfNeeded()) 226 if (exceptionState.throwIfNeeded())
228 return; 227 return;
229 228
230 v8SetReturnValue(info, value); 229 v8SetReturnValue(info, value);
231 } 230 }
232 231
233 } // namespace WebCore 232 } // namespace WebCore
OLDNEW
« no previous file with comments | « no previous file | Source/bindings/v8/custom/V8GeolocationCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698