Issue 328713004: Mojo: Use the MessagePipe creation helper whenever possible/reasonable in tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 328713004: Mojo: Use the MessagePipe creation helper whenever possible/reasonable in tests. (Closed)

Created:
6 years, 6 months ago by viettrungluu

Modified:
6 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mojo: Use the MessagePipe creation helper whenever possible/reasonable in tests. (This is mostly so that I don't have to update those call sites to specify NULL for options, after I add options to CreateMessagePipe.) R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276135

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -35 lines)			Patch
M	mojo/public/cpp/bindings/tests/array_unittest.cc	View	1 chunk	+12 lines, -16 lines	0 comments	Download
M	mojo/public/cpp/bindings/tests/connector_unittest.cc	View	3 chunks	+3 lines, -5 lines	0 comments	Download
M	mojo/public/cpp/bindings/tests/handle_passing_unittest.cc	View	1 chunk	+6 lines, -10 lines	0 comments	Download
M	mojo/public/cpp/bindings/tests/sample_service_unittest.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

6 years, 6 months ago (2014-06-10 20:51:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r276135 (presubmit successful).

Expand Messages | Collapse Messages