Mojo: Use the MessagePipe creation helper whenever possible/reasonable in tests.

mojo/public/cpp/bindings/tests/connector_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdlib.h>
 #include <string.h>
 
 #include "mojo/public/cpp/bindings/lib/connector.h"
 #include "mojo/public/cpp/bindings/lib/message_builder.h"
 #include "mojo/public/cpp/bindings/lib/message_queue.h"
@@ skipping 162 matching lines @@
 
   // Still not observed.
   EXPECT_FALSE(connector0.encountered_error());
 
   // Spin the RunLoop, and then we should start observing the closed pipe.
   PumpMessages();
 
   EXPECT_TRUE(connector0.encountered_error());
 }
 
-// Enable this test once MojoWriteMessage supports passing handles.
 TEST_F(ConnectorTest, MessageWithHandles) {
   internal::Connector connector0(handle0_.Pass());
   internal::Connector connector1(handle1_.Pass());
 
   const char kText[] = "hello world";
 
   Message message1;
   AllocMessage(kText, &message1);
 
-  ScopedMessagePipeHandle handles[2];
-  CreateMessagePipe(&handles[0], &handles[1]);
-  message1.mutable_handles()->push_back(handles[0].release());
+  MessagePipe pipe;
+  message1.mutable_handles()->push_back(pipe.handle0.release());
 
   connector0.Accept(&message1);
 
   // The message should have been transferred, releasing the handles.
   EXPECT_TRUE(message1.handles()->empty());
 
   MessageAccumulator accumulator;
   connector1.set_incoming_receiver(&accumulator);
 
   PumpMessages();
@@ skipping 10 matching lines @@
 
   // Now send a message to the transferred handle and confirm it's sent through
   // to the orginal pipe.
   // TODO(vtl): Do we need a better way of "downcasting" the handle types?
   ScopedMessagePipeHandle smph;
   smph.reset(MessagePipeHandle(message_received.handles()->front().value()));
   message_received.mutable_handles()->front() = Handle();
   // |smph| now owns this handle.
 
   internal::Connector connector_received(smph.Pass());
-  internal::Connector connector_original(handles[1].Pass());
+  internal::Connector connector_original(pipe.handle1.Pass());
 
   Message message2;
   AllocMessage(kText, &message2);
 
   connector_received.Accept(&message2);
   connector_original.set_incoming_receiver(&accumulator);
   PumpMessages();
 
   ASSERT_FALSE(accumulator.IsEmpty());
 
   accumulator.Pop(&message_received);
 
   EXPECT_EQ(
       std::string(kText),
       std::string(reinterpret_cast<const char*>(message_received.payload())));
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace mojo