Mojo: Use the MessagePipe creation helper whenever possible/reasonable in tests.

mojo/public/cpp/bindings/tests/array_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/public/cpp/bindings/array.h"
 #include "mojo/public/cpp/bindings/lib/array_serialization.h"
 #include "mojo/public/cpp/bindings/lib/fixed_buffer.h"
 #include "mojo/public/cpp/environment/environment.h"
 #include "mojo/public/interfaces/bindings/tests/sample_service.mojom.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 17 matching lines @@
   Array<bool> array(64);
   for (size_t i = 0; i < array.size(); ++i) {
     bool val = i % 3 == 0;
     array[i] = val;
     EXPECT_EQ(val, array.at(i));
   }
 }
 
 // Tests that Array<ScopedMessagePipeHandle> supports transferring handles.
 TEST(ArrayTest, Handle) {
-  ScopedMessagePipeHandle pipe0, pipe1;
-  CreateMessagePipe(&pipe0, &pipe1);
+  MessagePipe pipe;
+  Array<ScopedMessagePipeHandle> handles(2);
+  handles[0] = pipe.handle0.Pass();
+  handles[1].reset(pipe.handle1.release());
 
-  Array<ScopedMessagePipeHandle> handles(2);
-  handles[0] = pipe0.Pass();
-  handles[1].reset(pipe1.release());
-
-  EXPECT_FALSE(pipe0.is_valid());
-  EXPECT_FALSE(pipe1.is_valid());
+  EXPECT_FALSE(pipe.handle0.is_valid());
+  EXPECT_FALSE(pipe.handle1.is_valid());
 
   Array<ScopedMessagePipeHandle> handles2 = handles.Pass();
   EXPECT_TRUE(handles2[0].is_valid());
   EXPECT_TRUE(handles2[1].is_valid());
 
-  pipe0 = handles2[0].Pass();
-  EXPECT_TRUE(pipe0.is_valid());
+  ScopedMessagePipeHandle pipe_handle = handles2[0].Pass();
+  EXPECT_TRUE(pipe_handle.is_valid());
   EXPECT_FALSE(handles2[0].is_valid());
 }
 
 // Tests that Array<ScopedMessagePipeHandle> supports closing handles.
 TEST(ArrayTest, HandlesAreClosed) {
-  ScopedMessagePipeHandle pipe0, pipe1;
-  CreateMessagePipe(&pipe0, &pipe1);
-
-  MojoHandle pipe0_value = pipe0.get().value();
-  MojoHandle pipe1_value = pipe1.get().value();
+  MessagePipe pipe;
+  MojoHandle pipe0_value = pipe.handle0.get().value();
+  MojoHandle pipe1_value = pipe.handle0.get().value();
 
   {
     Array<ScopedMessagePipeHandle> handles(2);
-    handles[0] = pipe0.Pass();
-    handles[1].reset(pipe1.release());
+    handles[0] = pipe.handle0.Pass();
+    handles[1].reset(pipe.handle0.release());
   }
 
   // We expect the pipes to have been closed.
   EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, MojoClose(pipe0_value));
   EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, MojoClose(pipe1_value));
 }
 
 TEST(ArrayTest, Serialization_ArrayOfPOD) {
   Array<int32_t> array(4);
   for (size_t i = 0; i < array.size(); ++i)
@@ skipping 86 matching lines @@
   EXPECT_EQ(10U, array2.size());
   for (size_t i = 0; i < array2.size(); ++i) {
     char c = 'A' + 1;
     EXPECT_EQ(String(&c, 1), array2[i]);
   }
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace mojo