Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: mojo/public/cpp/bindings/tests/sample_service_unittest.cc

Issue 328713004: Mojo: Use the MessagePipe creation helper whenever possible/reasonable in tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/cpp/bindings/tests/handle_passing_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/bindings/tests/sample_service_unittest.cc
diff --git a/mojo/public/cpp/bindings/tests/sample_service_unittest.cc b/mojo/public/cpp/bindings/tests/sample_service_unittest.cc
index 23b0dbdf06f4aacc572c13dee81adcd0298cada1..c458fc098e63f4916cced089da16345b6315436a 100644
--- a/mojo/public/cpp/bindings/tests/sample_service_unittest.cc
+++ b/mojo/public/cpp/bindings/tests/sample_service_unittest.cc
@@ -81,9 +81,7 @@ FooPtr MakeFoo() {
array_of_array_of_bools[i] = array_of_bools.Pass();
}
- mojo::ScopedMessagePipeHandle pipe0, pipe1;
- mojo::CreateMessagePipe(&pipe0, &pipe1);
-
+ mojo::MessagePipe pipe;
FooPtr foo(Foo::New());
foo->name = name;
foo->x = 1;
@@ -94,7 +92,7 @@ FooPtr MakeFoo() {
foo->bar = bar.Pass();
foo->extra_bars = extra_bars.Pass();
foo->data = data.Pass();
- foo->source = pipe1.Pass();
+ foo->source = pipe.handle1.Pass();
foo->input_streams = input_streams.Pass();
foo->output_streams = output_streams.Pass();
foo->array_of_array_of_bools = array_of_array_of_bools.Pass();
« no previous file with comments | « mojo/public/cpp/bindings/tests/handle_passing_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698