Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 327323002: Start removing the double-negative !ASSERT_DISABLED (Closed)

Created:
6 years, 6 months ago by abarth-chromium
Modified:
6 years, 6 months ago
Reviewers:
dglazkov
CC:
abarth-chromium, aandrey+blink_chromium.org, darktears, apavlov+blink_chromium.org, arv+blink, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-rendering, blink-reviews-wtf_chromium.org, Rik, caseq+blink_chromium.org, danakj, devtools-reviews_chromium.org, dglazkov+blink, krit, eae+blinkwatch, ed+blinkwatch_opera.com, eustas+blink_chromium.org, f(malita), fs, gavinp+loader_chromium.org, groby+blinkspell_chromium.org, gyuyoung.kim_webkit.org, jamesr, Nate Chapin, jbroman, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, Mikhail, paulirish+reviews_chromium.org, pdr., pfeldman+blink_chromium.org, rwlbuis, Raymond Toy, rune+blink, Stephen Chennney, sergeyv+blink_chromium.org, sof, vsevik+blink_chromium.org, yurys+blink_chromium.org, zoltan1
Visibility:
Public.

Description

Start removing the double-negative !ASSERT_DISABLED This CL is a simple s/if !ASSERT_DISABLED/if ASSERT_ENABLED/. Subsequent CLs will clean up the remaining uses and then delete the macro. NOTRY=true R=dglazkov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175987

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -119 lines) Patch
M Source/bindings/v8/ExceptionStatePlaceholder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSStyleSheet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/FontBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ActiveDOMObject.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/ActiveDOMObject.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/DocumentLifecycle.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentLifecycle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/ScriptForbiddenScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TreeShared.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/EditorCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/TextIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/MemoryCache.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/frame/SuspendableTimer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/SuspendableTimer.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLCanvasElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorCounters.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/DragController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/FocusController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Page.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/LayoutState.h View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/LayoutState.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBlockFlow.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderGeometryMap.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderGeometryMap.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderInline.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderLayerStackingNode.h View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderLayerStackingNode.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderView.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/compositing/CompositingInputsUpdater.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositingInputsUpdater.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositingRequirementsUpdater.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/GraphicsLayerTreeBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/GraphicsLayerUpdater.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/GraphicsLayerUpdater.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGDocumentExtensions.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGDocumentExtensions.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGUseElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/InternalSettings.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XPathStep.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/Database.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseManager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/DatabaseManager.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/Supplementable.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/audio/android/FFTFrameOpenMAXDLAndroid.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/ffmpeg/FFTFrameFFMPEG.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/FontCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/BitmapImage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/BitmapImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/Canvas2DLayerBridge.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/GraphicsContext.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/GraphicsContext.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/graphics/Image.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/Path.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/Path.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/image-decoders/ImageFrame.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/image-decoders/ImageFrame.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/dtoa/cached-powers.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
abarth-chromium
6 years, 6 months ago (2014-06-11 20:07:12 UTC) #1
dglazkov
lgtm
6 years, 6 months ago (2014-06-11 20:07:41 UTC) #2
abarth-chromium
6 years, 6 months ago (2014-06-11 20:07:46 UTC) #3
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 6 months ago (2014-06-11 20:11:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/327323002/1
6 years, 6 months ago (2014-06-11 20:11:40 UTC) #5
abarth-chromium
The CQ bit was unchecked by abarth@chromium.org
6 years, 6 months ago (2014-06-11 20:14:47 UTC) #6
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 6 months ago (2014-06-11 20:15:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/327323002/1
6 years, 6 months ago (2014-06-11 20:15:10 UTC) #8
Nils Barth (inactive)
On 2014/06/11 20:07:41, dglazkov wrote: > lgtm Shouldn't this be: !lbtm ? ;)
6 years, 6 months ago (2014-06-12 00:53:51 UTC) #9
dglazkov
On 2014/06/12 at 00:53:51, nbarth wrote: > On 2014/06/11 20:07:41, dglazkov wrote: > > lgtm ...
6 years, 6 months ago (2014-06-12 03:02:46 UTC) #10
abarth-chromium
The CQ bit was unchecked by abarth@chromium.org
6 years, 6 months ago (2014-06-12 03:32:08 UTC) #11
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 6 months ago (2014-06-12 03:52:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/327323002/1
6 years, 6 months ago (2014-06-12 03:54:13 UTC) #13
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 05:34:57 UTC) #14
Message was sent while issue was closed. 
Change committed as 175987

Powered by Google App Engine
This is Rietveld 408576698