Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Side by Side Diff: Source/core/frame/SuspendableTimer.cpp

Issue 327323002: Start removing the double-negative !ASSERT_DISABLED (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/frame/SuspendableTimer.h ('k') | Source/core/html/HTMLCanvasElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 16 matching lines...) Expand all
27 #include "config.h" 27 #include "config.h"
28 #include "core/frame/SuspendableTimer.h" 28 #include "core/frame/SuspendableTimer.h"
29 29
30 namespace WebCore { 30 namespace WebCore {
31 31
32 SuspendableTimer::SuspendableTimer(ExecutionContext* context) 32 SuspendableTimer::SuspendableTimer(ExecutionContext* context)
33 : ActiveDOMObject(context) 33 : ActiveDOMObject(context)
34 , m_nextFireInterval(0) 34 , m_nextFireInterval(0)
35 , m_repeatInterval(0) 35 , m_repeatInterval(0)
36 , m_active(false) 36 , m_active(false)
37 #if !ASSERT_DISABLED 37 #if ASSERT_ENABLED
38 , m_suspended(false) 38 , m_suspended(false)
39 #endif 39 #endif
40 { 40 {
41 } 41 }
42 42
43 SuspendableTimer::~SuspendableTimer() 43 SuspendableTimer::~SuspendableTimer()
44 { 44 {
45 } 45 }
46 46
47 bool SuspendableTimer::hasPendingActivity() const 47 bool SuspendableTimer::hasPendingActivity() const
48 { 48 {
49 return isActive(); 49 return isActive();
50 } 50 }
51 51
52 void SuspendableTimer::stop() 52 void SuspendableTimer::stop()
53 { 53 {
54 TimerBase::stop(); 54 TimerBase::stop();
55 } 55 }
56 56
57 void SuspendableTimer::suspend() 57 void SuspendableTimer::suspend()
58 { 58 {
59 #if !ASSERT_DISABLED 59 #if ASSERT_ENABLED
60 ASSERT(!m_suspended); 60 ASSERT(!m_suspended);
61 m_suspended = true; 61 m_suspended = true;
62 #endif 62 #endif
63 m_active = isActive(); 63 m_active = isActive();
64 if (m_active) { 64 if (m_active) {
65 m_nextFireInterval = nextUnalignedFireInterval(); 65 m_nextFireInterval = nextUnalignedFireInterval();
66 m_repeatInterval = repeatInterval(); 66 m_repeatInterval = repeatInterval();
67 TimerBase::stop(); 67 TimerBase::stop();
68 } 68 }
69 } 69 }
70 70
71 void SuspendableTimer::resume() 71 void SuspendableTimer::resume()
72 { 72 {
73 #if !ASSERT_DISABLED 73 #if ASSERT_ENABLED
74 ASSERT(m_suspended); 74 ASSERT(m_suspended);
75 m_suspended = false; 75 m_suspended = false;
76 #endif 76 #endif
77 // FIXME: FROM_HERE is wrong here. 77 // FIXME: FROM_HERE is wrong here.
78 if (m_active) 78 if (m_active)
79 start(m_nextFireInterval, m_repeatInterval, FROM_HERE); 79 start(m_nextFireInterval, m_repeatInterval, FROM_HERE);
80 } 80 }
81 81
82 } // namespace WebCore 82 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/frame/SuspendableTimer.h ('k') | Source/core/html/HTMLCanvasElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698