Source/core/rendering/compositing/RenderLayerCompositor.cpp - Issue 327323002: Start removing the double-negative !ASSERT_DISABLED

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/compositing/RenderLayerCompositor.cpp

Issue 327323002: Start removing the double-negative !ASSERT_DISABLED (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/compositing/RenderLayerCompositor.cpp

diff --git a/Source/core/rendering/compositing/RenderLayerCompositor.cpp b/Source/core/rendering/compositing/RenderLayerCompositor.cpp

index d4fab7723c1051b906d53c92c08299e1c91fdc01..9314ba93e544b1ddd821269b5b246337148d873b 100644

--- a/Source/core/rendering/compositing/RenderLayerCompositor.cpp

+++ b/Source/core/rendering/compositing/RenderLayerCompositor.cpp

@@ -339,7 +339,7 @@ void RenderLayerCompositor::updateIfNeeded()

if (updater.needsRebuildTree())

updateType = std::max(updateType, CompositingUpdateRebuildTree);

-#if !ASSERT_DISABLED

+#if ASSERT_ENABLED

// FIXME: Move this check to the end of the compositing update.

GraphicsLayerUpdater::assertNeedsToUpdateGraphicsLayerBitsCleared(*updateRoot);

#endif

@@ -678,7 +678,7 @@ void RenderLayerCompositor::recursiveRepaintLayer(RenderLayer* layer)

if (layer->compositingState() == PaintsIntoOwnBacking)

layer->repainter().setBackingNeedsRepaint();

-#if !ASSERT_DISABLED

+#if ASSERT_ENABLED

LayerListMutationDetector mutationChecker(layer->stackingNode());

#endif