Source/core/dom/ActiveDOMObject.cpp - Issue 327323002: Start removing the double-negative !ASSERT_DISABLED

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/ActiveDOMObject.cpp

Issue 327323002: Start removing the double-negative !ASSERT_DISABLED (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/ActiveDOMObject.cpp

diff --git a/Source/core/dom/ActiveDOMObject.cpp b/Source/core/dom/ActiveDOMObject.cpp

index 44e6976e06cb3618eb711fe362416c0cb834705e..78e88e8c6e64bdb78c9be3e56fe28db63b23f5fc 100644

--- a/Source/core/dom/ActiveDOMObject.cpp

+++ b/Source/core/dom/ActiveDOMObject.cpp

@@ -34,7 +34,7 @@ namespace WebCore {

ActiveDOMObject::ActiveDOMObject(ExecutionContext* executionContext)

: ContextLifecycleObserver(executionContext, ActiveDOMObjectType)

, m_pendingActivityCount(0)

-#if !ASSERT_DISABLED

+#if ASSERT_ENABLED

, m_suspendIfNeededCalled(false)

#endif

{

@@ -58,7 +58,7 @@ ActiveDOMObject::~ActiveDOMObject()

void ActiveDOMObject::suspendIfNeeded()

{

-#if !ASSERT_DISABLED

+#if ASSERT_ENABLED

ASSERT(!m_suspendIfNeededCalled);

m_suspendIfNeededCalled = true;

#endif

« no previous file with comments | « Source/core/dom/ActiveDOMObject.h ('k') | Source/core/dom/DocumentLifecycle.h » ('j') | no next file with comments »