Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 32713002: Move more data from .data to the .rodata section (Closed)

Created:
7 years, 2 months ago by Inactive
Modified:
7 years, 2 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, abarth-chromium, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, zoltan1, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, jchaffraix+rendering, devtools-reviews_chromium.org, pdr, f(malita), Stephen Chennney, aandrey+blink_chromium.org
Visibility:
Public.

Description

Move more data from .data to the .rodata section Move more data from .data to the .rodata section so that it can be shared between different instances of the library on mobile / Android. In particular, the following data was moved: - Property names in the generated TypeBuilder class - s_resourceType in SVG rendering classes - InspectorDebuggerAgent::backtraceObjectGroup string - TextEncodingRegistry's textEncodingNameBlacklist array This also got rid of 7 relocations according to relinfo. R=abarth BUG=249746 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160371

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -24 lines) Patch
M Source/core/inspector/CodeGeneratorInspector.py View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceClipper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceClipper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceLinearGradient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceLinearGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceMarker.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceMarker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceMasker.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceMasker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourcePattern.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourcePattern.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceRadialGradient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceRadialGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceSolidColor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceSolidColor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/network/ResourceError.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/network/ResourceError.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/text/TextEncodingRegistry.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Inactive
7 years, 2 months ago (2013-10-21 16:05:37 UTC) #1
digit1
lgtm (thanks Chris)
7 years, 2 months ago (2013-10-21 16:12:50 UTC) #2
Inactive
7 years, 2 months ago (2013-10-22 13:22:10 UTC) #3
Inactive
ping review?
7 years, 2 months ago (2013-10-23 13:28:11 UTC) #4
abarth-chromium
lgtm
7 years, 2 months ago (2013-10-23 18:30:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/32713002/1
7 years, 2 months ago (2013-10-23 18:33:28 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-10-23 19:56:44 UTC) #7
Message was sent while issue was closed. 
Change committed as 160371

Powered by Google App Engine
This is Rietveld 408576698