Issue 325603002: Clean up Skia for Clang's -Wtautological-undefined-compare

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 325603002: Clean up Skia for Clang's -Wtautological-undefined-compare (Closed)

Created:
6 years, 6 months ago by mtklein_C

Modified:
6 years, 6 months ago

Reviewers:
mtklein, reed2, reed1

CC:
skia-review_googlegroups.com, Nico, bungeman-skia

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

Clean up Skia for Clang's -Wtautological-undefined-compare This is blocking Chrome from rolling a new Clang, and me too for our TSAN bots. BUG=chromium:381910 Committed: https://skia.googlesource.com/skia/+/b77c7ef

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -16 lines)			Patch
M	include/core/SkTLazy.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/core/SkPaint.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/core/SkRegion.cpp	View	1 chunk	+0 lines, -6 lines	0 comments	Download

Total messages: 4 (0 generated)

mtklein

Landed this without review so we don't block Chrome. This CL is certainly worth review ...

6 years, 6 months ago (2014-06-07 23:19:29 UTC) #3

Message was sent while issue was closed.

lgtm -- lets talk about what clang was doing on Monday