include/core/SkTLazy.h - Issue 325603002: Clean up Skia for Clang's -Wtautological-undefined-compare

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkTLazy.h

Issue 325603002: Clean up Skia for Clang's -Wtautological-undefined-compare (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/core/SkTLazy.h

diff --git a/include/core/SkTLazy.h b/include/core/SkTLazy.h

index 518beecc8571448573f8da98134d68553c3ff482..a291e22a137692226425776dc9efaafb860836bb 100644

--- a/include/core/SkTLazy.h

+++ b/include/core/SkTLazy.h

@@ -66,11 +66,6 @@ public:

* contents.

T* set(const T& src) {

- // Diagnoistic. May remove later. See crbug.com/364224

- if (NULL == &src) {

- sk_throw();

- }

if (this->isValid()) {

*fPtr = src;

} else {

« no previous file with comments | « no previous file | src/core/SkPaint.cpp » ('j') | no next file with comments »