src/core/SkRegion.cpp - Issue 325603002: Clean up Skia for Clang's -Wtautological-undefined-compare

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkRegion.cpp

Issue 325603002: Clean up Skia for Clang's -Wtautological-undefined-compare (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkRegion.cpp

diff --git a/src/core/SkRegion.cpp b/src/core/SkRegion.cpp

index 98670b6b520e003f46f46618391a90c8feb01c6e..24d7248582f681d6461976ac919d5985eda68b54 100644

--- a/src/core/SkRegion.cpp

+++ b/src/core/SkRegion.cpp

@@ -212,12 +212,6 @@ char* SkRegion::toString() {

///////////////////////////////////////////////////////////////////////////////

int SkRegion::count_runtype_values(int* itop, int* ibot) const {

- if (this == NULL) {

- *itop = SK_MinS32;

- *ibot = SK_MaxS32;

- return 0;

- }

int maxT;

if (this->isRect()) {

« no previous file with comments | « src/core/SkPaint.cpp ('k') | no next file » | no next file with comments »