src/core/SkPaint.cpp - Issue 325603002: Clean up Skia for Clang's -Wtautological-undefined-compare

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkPaint.cpp

Issue 325603002: Clean up Skia for Clang's -Wtautological-undefined-compare (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkPaint.cpp

diff --git a/src/core/SkPaint.cpp b/src/core/SkPaint.cpp

index f3bf01bfafc5ca30e0507190a8ffee37f8a5efaa..78d947020b20442ac8bafcc63f14d752bf2f0c83 100644

--- a/src/core/SkPaint.cpp

+++ b/src/core/SkPaint.cpp

@@ -106,11 +106,6 @@ SkPaint::SkPaint() {

}

SkPaint::SkPaint(const SkPaint& src) {

- // Diagnoistic. May remove later. See crbug.com/364224

- if (NULL == &src) {

- sk_throw();

- }

#define COPY(field) field = src.field

#define REF_COPY(field) field = SkSafeRef(src.field)

« no previous file with comments | « include/core/SkTLazy.h ('k') | src/core/SkRegion.cpp » ('j') | no next file with comments »