Add a do_not_sync pref to ExtensionPrefs.

Add a do_not_sync pref to ExtensionPrefs.

Split from https://codereview.chromium.org/308003005/ for extensions
system changes that allows to install a none syncable Extension.

- Add a do_not_sync pref to ExtensionPrefs;
- Add a kInstallFlagDoNotSync that CrxInstaller uses to initialize the pref;
- Update util::ShouldSyncApp and add ShouldSyncExtension to use the pref to skip sync in ExtensionSyncService;

BUG=358791
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277269

[not at google - send to devlin, 2014-06-09 22:43:46]

this is a lot of changes for just threading through a single flag.

I'll try and submit https://codereview.chromium.org/322893002 asap to make your
life much easier.

[xiyuan, 2014-06-09 22:49:04]

On 2014/06/09 22:43:46, kalman wrote:
> this is a lot of changes for just threading through a single flag.
> 
> I'll try and submit https://codereview.chromium.org/322893002 asap to make
your
> life much easier.

Yep. A flag makes much more sense and more readable than pushing around a bunch
of booleans. Thanks for doing that.

[not at google - send to devlin, 2014-06-13 16:28:52]

Sorry it took so long, but the patch to make this a bitmask has been subitted,
so you should be able to rebase this patch and make it much smaller :)

[xiyuan, 2014-06-13 19:49:44]

Rebased. Must simpler now. PTAL. Thanks.

[not at google - send to devlin, 2014-06-13 20:01:22]

lgtm

https://codereview.chromium.org/323843003/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/crx_installer.h (right):

https://codereview.chromium.org/323843003/diff/20001/chrome/browser/extension...
chrome/browser/extensions/crx_installer.h:205: }
now that there are 3 of these, could you write a function like
set_install_flag(flag, val)?

https://codereview.chromium.org/323843003/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/extension_sync_bundle.cc (right):

https://codereview.chromium.org/323843003/diff/20001/chrome/browser/extension...
chrome/browser/extensions/extension_sync_bundle.cc:155: if (IsSyncing() &&
util::ShouldSyncExtension(&extension, profile) &&
could you add a comment to sync_helper.h saying "you probably want to use
util::ShoudSyncExtension not these methods".

https://codereview.chromium.org/323843003/diff/20001/extensions/browser/exten...
File extensions/browser/extension_prefs.cc (right):

https://codereview.chromium.org/323843003/diff/20001/extensions/browser/exten...
extensions/browser/extension_prefs.cc:2148: extension_dict->Set(kPrefDoNotSync,
new base::FundamentalValue(true));
I think you need an else extension_dict->Remove(kPrefDoNotSync) call here? it
looks like this function is called when an extension updates, with its old pref
values... though I'm not totally sure.

[xiyuan, 2014-06-13 20:35:43]

https://codereview.chromium.org/323843003/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/crx_installer.h (right):

https://codereview.chromium.org/323843003/diff/20001/chrome/browser/extension...
chrome/browser/extensions/crx_installer.h:205: }
On 2014/06/13 20:01:22, kalman wrote:
> now that there are 3 of these, could you write a function like
> set_install_flag(flag, val)?

Done.

https://codereview.chromium.org/323843003/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/extension_sync_bundle.cc (right):

https://codereview.chromium.org/323843003/diff/20001/chrome/browser/extension...
chrome/browser/extensions/extension_sync_bundle.cc:155: if (IsSyncing() &&
util::ShouldSyncExtension(&extension, profile) &&
On 2014/06/13 20:01:22, kalman wrote:
> could you add a comment to sync_helper.h saying "you probably want to use
> util::ShoudSyncExtension not these methods".

Done.

https://codereview.chromium.org/323843003/diff/20001/extensions/browser/exten...
File extensions/browser/extension_prefs.cc (right):

https://codereview.chromium.org/323843003/diff/20001/extensions/browser/exten...
extensions/browser/extension_prefs.cc:2148: extension_dict->Set(kPrefDoNotSync,
new base::FundamentalValue(true));
On 2014/06/13 20:01:22, kalman wrote:
> I think you need an else extension_dict->Remove(kPrefDoNotSync) call here? it
> looks like this function is called when an extension updates, with its old
pref
> values... though I'm not totally sure.

Done. 

Yes, it's called for update as well. And fix a bug in extension_service.cc to
make sure update does not lose the bit.

[xiyuan, 2014-06-14 03:31:30]

The CQ bit was checked by xiyuan@chromium.org

[commit-bot: I haz the power, 2014-06-14 03:33:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/xiyuan@chromium.org/323843003/40001

[commit-bot: I haz the power, 2014-06-14 20:28:10]

Change committed as 277269