Add a do_not_sync pref to ExtensionPrefs.

chrome/browser/extensions/crx_installer_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/at_exit.h"
 #include "base/memory/ref_counted.h"
 #include "chrome/browser/download/download_crx_util.h"
 #include "chrome/browser/extensions/browser_action_test_util.h"
 #include "chrome/browser/extensions/crx_installer.h"
 #include "chrome/browser/extensions/extension_browsertest.h"
 #include "chrome/browser/extensions/extension_install_prompt.h"
 #include "chrome/browser/extensions/extension_service.h"
+#include "chrome/browser/extensions/extension_util.h"
 #include "chrome/browser/extensions/fake_safe_browsing_database_manager.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/download_manager.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/test/browser_test_utils.h"
@@ skipping 20 matching lines @@
 namespace extensions {
 
 namespace {
 
 class MockInstallPrompt;
 
 // This class holds information about things that happen with a
 // MockInstallPrompt. We create the MockInstallPrompt but need to pass
 // ownership of it to CrxInstaller, so it isn't safe to hang this data on
 // MockInstallPrompt itself becuase we can't guarantee it's lifetime.
-class MockPromptProxy :
-      public base::RefCountedThreadSafe<MockPromptProxy> {
+class MockPromptProxy : public base::RefCountedThreadSafe<MockPromptProxy> {
  public:
   explicit MockPromptProxy(content::WebContents* web_contents);
 
   bool did_succeed() const { return !extension_id_.empty(); }
   const std::string& extension_id() { return extension_id_; }
   bool confirmation_requested() const { return confirmation_requested_; }
   const base::string16& error() const { return error_; }
 
   // To have any effect, this should be called before CreatePrompt.
   void set_record_oauth2_grant(bool record_oauth2_grant) {
@@ skipping 44 matching lines @@
   }
   virtual void OnInstallFailure(const CrxInstallerError& error) OVERRIDE {
     proxy_->set_error(error.message());
     base::MessageLoopForUI::current()->Quit();
   }
 
  private:
   scoped_refptr<MockPromptProxy> proxy_;
 };
 
-
-MockPromptProxy::MockPromptProxy(content::WebContents* web_contents) :
-    web_contents_(web_contents),
-    confirmation_requested_(false) {
+MockPromptProxy::MockPromptProxy(content::WebContents* web_contents)
+    : web_contents_(web_contents), confirmation_requested_(false) {
 }
 
 MockPromptProxy::~MockPromptProxy() {}
 
 scoped_ptr<ExtensionInstallPrompt> MockPromptProxy::CreatePrompt() {
   scoped_ptr<MockInstallPrompt> prompt(
       new MockInstallPrompt(web_contents_, this));
   if (record_oauth2_grant_.get())
     prompt->set_record_oauth2_grant(*record_oauth2_grant_.get());
   return prompt.PassAs<ExtensionInstallPrompt>();
@@ skipping 226 matching lines @@
           IDS_EXTENSION_INSTALL_DISALLOWED_ON_SITE),
           mock_prompt->error()) << kTestData[i];
     }
   }
 }
 
 IN_PROC_BROWSER_TEST_F(ExtensionCrxInstallerTest, HiDpiThemeTest) {
   base::FilePath crx_path = test_data_dir_.AppendASCII("theme_hidpi_crx");
   crx_path = crx_path.AppendASCII("theme_hidpi.crx");
 
-  ASSERT_TRUE(InstallExtension(crx_path,1));
+  ASSERT_TRUE(InstallExtension(crx_path, 1));
 
   const std::string extension_id("gllekhaobjnhgeagipipnkpmmmpchacm");
   ExtensionService* service = extensions::ExtensionSystem::Get(
       browser()->profile())->extension_service();
   ASSERT_TRUE(service);
   const extensions::Extension* extension =
      service->GetExtensionById(extension_id, false);
   ASSERT_TRUE(extension);
   EXPECT_EQ(extension_id, extension->id());
 
@@ skipping 41 matching lines @@
 
   // Install version 2 of the extension and check that it is indeed delayed.
   ASSERT_TRUE(UpdateExtensionWaitForIdle(
       extension_id, crx_path.AppendASCII("v2.crx"), 0));
 
   ASSERT_EQ(1u, service->delayed_installs()->size());
   extension = service->GetExtensionById(extension_id, false);
   ASSERT_EQ("1.0", extension->version()->GetString());
 
   // Make the extension idle again by closing the popup. This should not trigger
-  //the delayed install.
+  // the delayed install.
   content::RenderProcessHostWatcher terminated_observer(
       extension_host->render_process_host(),
       content::RenderProcessHostWatcher::WATCH_FOR_HOST_DESTRUCTION);
   extension_host->render_view_host()->ClosePage();
   terminated_observer.Wait();
   ASSERT_EQ(1u, service->delayed_installs()->size());
 
   // Install version 3 of the extension. Because the extension is idle,
   // this install should succeed.
   ASSERT_TRUE(UpdateExtensionWaitForIdle(
@@ skipping 86 matching lines @@
     // Wait for background task completion that sends replay to UI thread.
     content::BrowserThread::GetBlockingPool()->FlushForTesting();
     // Wait for UI thread task completion.
     base::RunLoop().RunUntilIdle();
   }
 
   EXPECT_FALSE(base::PathExists(extension_path));
 }
 #endif
 
+IN_PROC_BROWSER_TEST_F(ExtensionCrxInstallerTest, DoNotSync) {
+  ExtensionService* service = extensions::ExtensionSystem::Get(
+                                  browser()->profile())->extension_service();
+  scoped_refptr<CrxInstaller> crx_installer(
+      CrxInstaller::CreateSilent(service));
+  crx_installer->set_install_flag(kInstallFlagDoNotSync, true);
+  crx_installer->InstallCrx(test_data_dir_.AppendASCII("good.crx"));
+  EXPECT_TRUE(WaitForCrxInstallerDone());
+  ASSERT_TRUE(crx_installer->extension());
+
+  const ExtensionPrefs* extension_prefs =
+      ExtensionPrefs::Get(browser()->profile());
+  EXPECT_TRUE(extension_prefs->DoNotSync(crx_installer->extension()->id()));
+  EXPECT_FALSE(extensions::util::ShouldSyncApp(crx_installer->extension(),
+                                               browser()->profile()));
+}
+
 }  // namespace extensions