Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 323833003: Create ActionRunner wrapper API over TapAction and ClickElementAction. (Closed)

Created:
6 years, 6 months ago by chrishenry
Modified:
6 years, 6 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Create ActionRunner wrapper API over TapAction and ClickElementAction. Add EvaluateJavaScript to ActionRunner. Replace all existing use cases. BUG=361809 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276553

Patch Set 1 : #

Patch Set 2 : Undo deletion of wait_until (to be done in separate patch). #

Total comments: 4

Patch Set 3 : Add BeginGestureInteraction. #

Patch Set 4 : Rebasing to head. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+343 lines, -335 lines) Patch
M tools/perf/page_sets/browser_control_click.py View 3 chunks +6 lines, -12 lines 0 comments Download
M tools/perf/page_sets/calendar_forward_backward.py View 1 chunk +8 lines, -32 lines 0 comments Download
M tools/perf/page_sets/gmail_alt_threadlist_conversation.py View 2 chunks +29 lines, -10 lines 0 comments Download
M tools/perf/page_sets/gmail_alt_two_labels.py View 2 chunks +17 lines, -10 lines 0 comments Download
M tools/perf/page_sets/gmail_compose_discard.py View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download
M tools/perf/page_sets/gmail_expand_collapse_conversation.py View 1 chunk +4 lines, -16 lines 0 comments Download
M tools/perf/page_sets/indexeddb_offline.py View 1 2 3 1 chunk +2 lines, -8 lines 0 comments Download
M tools/perf/page_sets/key_mobile_sites.py View 1 chunk +1 line, -4 lines 0 comments Download
M tools/perf/page_sets/key_silk_cases.py View 1 2 3 chunks +16 lines, -17 lines 0 comments Download
M tools/perf/page_sets/plus_alt_posts_photos.py View 1 chunk +2 lines, -8 lines 0 comments Download
M tools/perf/page_sets/polymer.py View 1 chunk +12 lines, -16 lines 0 comments Download
M tools/perf/page_sets/top_25.py View 8 chunks +66 lines, -147 lines 0 comments Download
M tools/perf/page_sets/webrtc_cases.py View 1 chunk +6 lines, -24 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/action_runner.py View 1 2 3 5 chunks +82 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/action_runner_unittest.py View 2 chunks +41 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/all_page_actions.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/gesture_action.py View 1 2 chunks +8 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/javascript_click.py View 1 chunk +9 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/tap.py View 1 chunk +16 lines, -12 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py View 1 chunk +1 line, -2 lines 0 comments Download
A tools/telemetry/unittest_data/page_with_clickables.html View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 30 (0 generated)
chrishenry
6 years, 6 months ago (2014-06-10 21:53:37 UTC) #1
nednguyen
https://codereview.chromium.org/323833003/diff/80001/tools/perf/page_sets/key_silk_cases.py File tools/perf/page_sets/key_silk_cases.py (right): https://codereview.chromium.org/323833003/diff/80001/tools/perf/page_sets/key_silk_cases.py#newcode382 tools/perf/page_sets/key_silk_cases.py:382: interaction = action_runner.BeginInteraction( May be we should have a ...
6 years, 6 months ago (2014-06-10 22:48:58 UTC) #2
chrishenry
https://codereview.chromium.org/323833003/diff/80001/tools/perf/page_sets/key_silk_cases.py File tools/perf/page_sets/key_silk_cases.py (right): https://codereview.chromium.org/323833003/diff/80001/tools/perf/page_sets/key_silk_cases.py#newcode382 tools/perf/page_sets/key_silk_cases.py:382: interaction = action_runner.BeginInteraction( On 2014/06/10 22:48:58, nednguyen wrote: > ...
6 years, 6 months ago (2014-06-10 23:22:50 UTC) #3
nednguyen
lgtm
6 years, 6 months ago (2014-06-10 23:24:07 UTC) #4
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 6 months ago (2014-06-10 23:24:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/323833003/100001
6 years, 6 months ago (2014-06-10 23:27:16 UTC) #6
chrishenry
The CQ bit was unchecked by chrishenry@google.com
6 years, 6 months ago (2014-06-10 23:29:27 UTC) #7
chrishenry
The CQ bit was checked by chrishenry@google.com
6 years, 6 months ago (2014-06-11 14:19:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/323833003/130001
6 years, 6 months ago (2014-06-11 14:21:48 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 21:51:47 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 22:43:45 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/19707)
6 years, 6 months ago (2014-06-11 22:43:46 UTC) #12
chrishenry
The CQ bit was checked by chrishenry@google.com
6 years, 6 months ago (2014-06-11 22:51:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/323833003/130001
6 years, 6 months ago (2014-06-11 22:52:40 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 22:55:25 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 22:57:57 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/19816)
6 years, 6 months ago (2014-06-11 22:57:58 UTC) #17
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 6 months ago (2014-06-11 23:00:40 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/323833003/130001
6 years, 6 months ago (2014-06-11 23:01:46 UTC) #19
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 23:18:22 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 23:28:44 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/19851)
6 years, 6 months ago (2014-06-11 23:28:45 UTC) #22
chrishenry
The CQ bit was checked by chrishenry@google.com
6 years, 6 months ago (2014-06-12 00:36:13 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/323833003/130001
6 years, 6 months ago (2014-06-12 00:37:39 UTC) #24
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-12 00:40:08 UTC) #25
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 00:42:59 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/19914)
6 years, 6 months ago (2014-06-12 00:43:00 UTC) #27
chrishenry
The CQ bit was checked by chrishenry@google.com
6 years, 6 months ago (2014-06-12 02:33:03 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/323833003/130001
6 years, 6 months ago (2014-06-12 02:34:19 UTC) #29
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 06:48:25 UTC) #30
Message was sent while issue was closed. 
Change committed as 276553

Powered by Google App Engine
This is Rietveld 408576698