Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: tools/perf/page_sets/browser_control_click.py

Issue 323833003: Create ActionRunner wrapper API over TapAction and ClickElementAction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebasing to head. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/page_sets/calendar_forward_backward.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/browser_control_click.py
diff --git a/tools/perf/page_sets/browser_control_click.py b/tools/perf/page_sets/browser_control_click.py
index 72c55a477cba35a0cc889ed2872184a353150f35..d1431529efacb61d48b2453697874529a34c7408 100644
--- a/tools/perf/page_sets/browser_control_click.py
+++ b/tools/perf/page_sets/browser_control_click.py
@@ -15,9 +15,9 @@ class BrowserControlClickPage(page_module.Page):
def __init__(self, page_set):
super(BrowserControlClickPage, self).__init__(
- url='file://endure/browser_control_click.html',
- page_set=page_set,
- name='browser_control_click')
+ url='file://endure/browser_control_click.html',
+ page_set=page_set,
+ name='browser_control_click')
self.user_agent_type = 'desktop'
def RunNavigateSteps(self, action_runner):
@@ -25,15 +25,9 @@ class BrowserControlClickPage(page_module.Page):
action_runner.WaitForElement('#attach')
def RunEndure(self, action_runner):
- action_runner.RunAction(ClickElementAction(
- {
- 'xpath': 'id("attach")'
- }))
+ action_runner.ClickElement('#attach')
action_runner.Wait(0.5)
- action_runner.RunAction(ClickElementAction(
- {
- 'xpath': 'id("detach")'
- }))
+ action_runner.ClickElement('#detach')
action_runner.Wait(0.5)
@@ -43,6 +37,6 @@ class BrowserControlClickPageSet(page_set_module.PageSet):
def __init__(self):
super(BrowserControlClickPageSet, self).__init__(
- user_agent_type='desktop')
+ user_agent_type='desktop')
self.AddPage(BrowserControlClickPage(self))
« no previous file with comments | « no previous file | tools/perf/page_sets/calendar_forward_backward.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698