Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1150)

Unified Diff: tools/perf/page_sets/gmail_alt_two_labels.py

Issue 323833003: Create ActionRunner wrapper API over TapAction and ClickElementAction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebasing to head. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/page_sets/gmail_alt_two_labels.py
diff --git a/tools/perf/page_sets/gmail_alt_two_labels.py b/tools/perf/page_sets/gmail_alt_two_labels.py
index c23ce1a94792a2fda69aeae3ef0cd1ca1fffdc1d..f81720dbb837f21bff5ef2f05eef41b1e1799834 100644
--- a/tools/perf/page_sets/gmail_alt_two_labels.py
+++ b/tools/perf/page_sets/gmail_alt_two_labels.py
@@ -7,6 +7,15 @@ from telemetry.page import page as page_module
from telemetry.page import page_set as page_set_module
+def _GetCurrentLocation(action_runner):
+ return action_runner.EvaluateJavaScript('document.location.href')
+
+
+def _WaitForLocationChange(action_runner, old_href):
+ action_runner.WaitForJavaScriptCondition(
+ 'document.location.href != "%s"' % old_href)
+
+
class GmailAltTwoLabelsPage(page_module.Page):
""" Why: Alternate between Inbox and Sent Mail """
@@ -29,17 +38,15 @@ class GmailAltTwoLabelsPage(page_module.Page):
'document.getElementById("gb") !== null')
def RunEndure(self, action_runner):
- action_runner.RunAction(ClickElementAction(
- {
- 'wait_until': {'condition': 'href_change'},
- 'selector': 'a[href="https://mail.google.com/mail/u/0/?shva=1#sent"]'
- }))
+ old_href = _GetCurrentLocation(action_runner)
+ action_runner.ClickElement(
+ 'a[href="https://mail.google.com/mail/u/0/?shva=1#sent"]')
+ _WaitForLocationChange(action_runner, old_href)
action_runner.Wait(1)
- action_runner.RunAction(ClickElementAction(
- {
- 'wait_until': {'condition': 'href_change'},
- 'selector': 'a[href="https://mail.google.com/mail/u/0/?shva=1#inbox"]'
- }))
+ old_href = _GetCurrentLocation(action_runner)
+ action_runner.ClickElement(
+ 'a[href="https://mail.google.com/mail/u/0/?shva=1#inbox"]')
+ _WaitForLocationChange(action_runner, old_href)
action_runner.Wait(1)
« no previous file with comments | « tools/perf/page_sets/gmail_alt_threadlist_conversation.py ('k') | tools/perf/page_sets/gmail_compose_discard.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698