Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: tools/telemetry/telemetry/page/actions/javascript_click.py

Issue 323833003: Create ActionRunner wrapper API over TapAction and ClickElementAction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebasing to head. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/actions/javascript_click.py
diff --git a/tools/telemetry/telemetry/page/actions/javascript_click.py b/tools/telemetry/telemetry/page/actions/javascript_click.py
index 2fc9fab6fbd3dd66e61b5dfcd1cc72d509e05323..82745a7551196774f372cb9e50b65d2279d0b032 100644
--- a/tools/telemetry/telemetry/page/actions/javascript_click.py
+++ b/tools/telemetry/telemetry/page/actions/javascript_click.py
@@ -17,7 +17,15 @@ class ClickElementAction(page_action.PageAction):
def RunAction(self, tab):
def DoClick():
- if hasattr(self, 'selector'):
+ if hasattr(self, 'element_function'):
+ code = '(%s).click();' % self.element_function
+ try:
+ tab.ExecuteJavaScript(code)
+ except exceptions.EvaluateException:
+ raise page_action.PageActionFailed(
+ 'Cannot find element with element_function ' +
+ self.element_function)
+ elif hasattr(self, 'selector'):
code = ('document.querySelector(\'' + _EscapeSelector(self.selector) +
'\').click();')
try:
« no previous file with comments | « tools/telemetry/telemetry/page/actions/gesture_action.py ('k') | tools/telemetry/telemetry/page/actions/tap.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698