Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 323513005: Revert of Gamma correction for distance field text. (Closed)

Created:
6 years, 6 months ago by scroggo
Modified:
6 years, 6 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Gamma correction for distance field text. (https://codereview.chromium.org/258883002/) Reason for revert: Memory leaks. I suspect this is due to the lack of destructors in SkAutoGlyphCache Original issue's description: > Gamma correction for distance field text. > > Handles both non-LCD and LCD text. Uses a texture to look up the gamma correction values for a given text color or luminance. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/4d517fdbb145cb95e5e935470df331e1b6667cfc NOTRY=true NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/919ed4c73633e92bfc6694161360c5c3f45728e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -376 lines) Patch
M include/core/SkPaint.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/core/SkGlyphCache.h View 2 chunks +17 lines, -52 lines 0 comments Download
M src/core/SkMaskGamma.h View 1 chunk +0 lines, -16 lines 0 comments Download
M src/core/SkPaint.cpp View 5 chunks +8 lines, -34 lines 0 comments Download
M src/core/SkScalerContext.h View 1 chunk +0 lines, -11 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 8 chunks +9 lines, -82 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.h View 7 chunks +6 lines, -34 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 17 chunks +32 lines, -143 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
scroggo
Created Revert of Gamma correction for distance field text.
6 years, 6 months ago (2014-06-09 20:01:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/323513005/1
6 years, 6 months ago (2014-06-09 20:02:24 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-09 20:02:25 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-09 20:02:25 UTC) #4
mtklein
lgtm
6 years, 6 months ago (2014-06-09 20:03:52 UTC) #5
mtklein
The CQ bit was unchecked by mtklein@google.com
6 years, 6 months ago (2014-06-09 20:06:04 UTC) #6
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-09 20:06:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/323513005/1
6 years, 6 months ago (2014-06-09 20:06:16 UTC) #8
commit-bot: I haz the power
Change committed as 919ed4c73633e92bfc6694161360c5c3f45728e8
6 years, 6 months ago (2014-06-09 20:06:39 UTC) #9
scroggo
6 years, 6 months ago (2014-06-09 20:09:06 UTC) #10
Message was sent while issue was closed.
On 2014/06/09 20:06:39, I haz the power (commit-bot) wrote:
> Change committed as 919ed4c73633e92bfc6694161360c5c3f45728e8

For future reference, there was no TBR etc, making the revert doomed to fail,
because the original CL was over 14 days old. See
https://code.google.com/p/skia/issues/detail?id=2587 (and feel free to complain
in the thread. I don't think this behavior helps anyone)

Powered by Google App Engine
This is Rietveld 408576698