Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 322163003: Rename AncestorDependentProperties to CompositingInputs (Closed)

Created:
6 years, 6 months ago by abarth-chromium
Modified:
6 years, 6 months ago
Reviewers:
chrishtr, esprehn
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-rendering, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rwlbuis, rune+blink, sof, Ian Vollick, zoltan1
Visibility:
Public.

Description

Rename AncestorDependentProperties to CompositingInputs This state on RenderLayer is specific to the compositor. The name AncestorDependentProperties hasn't aged well. In other places, we call these CompositingInputs, which seems more appropriate. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175925

Patch Set 1 #

Patch Set 2 : Fix typos #

Patch Set 3 : Moar renaming #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -220 lines) Patch
M Source/core/core.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/FrameView.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayer.h View 1 2 4 chunks +12 lines, -12 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 2 7 chunks +17 lines, -17 lines 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/rendering/compositing/CompositingInputsUpdater.h View 1 2 4 chunks +8 lines, -8 lines 0 comments Download
A + Source/core/rendering/compositing/CompositingInputsUpdater.cpp View 1 2 5 chunks +17 lines, -17 lines 0 comments Download
M Source/core/rendering/compositing/CompositingLayerAssigner.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
D Source/core/rendering/compositing/CompositingPropertyUpdater.h View 1 chunk +0 lines, -49 lines 0 comments Download
D Source/core/rendering/compositing/CompositingPropertyUpdater.cpp View 1 chunk +0 lines, -94 lines 0 comments Download
M Source/core/rendering/compositing/CompositingReasonFinder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositingRequirementsUpdater.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
abarth-chromium
6 years, 6 months ago (2014-06-10 20:04:10 UTC) #1
chrishtr
lgtm
6 years, 6 months ago (2014-06-10 20:53:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/322163003/20001
6 years, 6 months ago (2014-06-10 20:54:26 UTC) #3
esprehn
lgtm, might have been nice to go with setNeedsCompositingInputRecalc() to match style recalc and such. ...
6 years, 6 months ago (2014-06-10 21:04:26 UTC) #4
abarth-chromium
On 2014/06/10 at 21:04:26, esprehn wrote: > lgtm, might have been nice to go with ...
6 years, 6 months ago (2014-06-10 21:11:27 UTC) #5
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 6 months ago (2014-06-10 21:11:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/322163003/40001
6 years, 6 months ago (2014-06-10 21:11:50 UTC) #7
ojan
On 2014/06/10 at 21:11:27, abarth wrote: > On 2014/06/10 at 21:04:26, esprehn wrote: > > ...
6 years, 6 months ago (2014-06-10 21:37:09 UTC) #8
abarth-chromium
On 2014/06/10 at 21:37:09, ojan wrote: > On 2014/06/10 at 21:11:27, abarth wrote: > > ...
6 years, 6 months ago (2014-06-10 21:54:14 UTC) #9
esprehn
On 2014/06/10 at 21:54:14, abarth wrote: > On 2014/06/10 at 21:37:09, ojan wrote: > > ...
6 years, 6 months ago (2014-06-10 21:55:05 UTC) #10
commit-bot: I haz the power
Change committed as 175925
6 years, 6 months ago (2014-06-10 22:22:24 UTC) #11
ojan
On 2014/06/10 at 21:54:14, abarth wrote: > On 2014/06/10 at 21:37:09, ojan wrote: > > ...
6 years, 6 months ago (2014-06-11 01:58:02 UTC) #12
abarth-chromium
6 years, 6 months ago (2014-06-11 04:12:36 UTC) #13
Message was sent while issue was closed.
On 2014/06/11 at 01:58:02, ojan wrote:
> I didn't see the first version of the patch. I didn't really mean this as a
serious comment though. Sorry for the confusion.

No worries :)

Powered by Google App Engine
This is Rietveld 408576698