Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1518)

Unified Diff: Source/core/rendering/compositing/CompositingInputsUpdater.cpp

Issue 322163003: Rename AncestorDependentProperties to CompositingInputs (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Moar renaming Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/compositing/CompositingInputsUpdater.cpp
diff --git a/Source/core/rendering/compositing/CompositingPropertyUpdater.cpp b/Source/core/rendering/compositing/CompositingInputsUpdater.cpp
similarity index 68%
rename from Source/core/rendering/compositing/CompositingPropertyUpdater.cpp
rename to Source/core/rendering/compositing/CompositingInputsUpdater.cpp
index 4e9f5a1128a1a74b9f48cadb14dde968e3082509..34aff99ed5a9781123902b472fb47c080ba2f95e 100644
--- a/Source/core/rendering/compositing/CompositingPropertyUpdater.cpp
+++ b/Source/core/rendering/compositing/CompositingInputsUpdater.cpp
@@ -3,7 +3,7 @@
// found in the LICENSE file.
#include "config.h"
-#include "core/rendering/compositing/CompositingPropertyUpdater.h"
+#include "core/rendering/compositing/CompositingInputsUpdater.h"
#include "core/rendering/RenderBlock.h"
#include "core/rendering/RenderLayer.h"
@@ -11,20 +11,20 @@
namespace WebCore {
-CompositingPropertyUpdater::CompositingPropertyUpdater(RenderLayer* rootRenderLayer)
+CompositingInputsUpdater::CompositingInputsUpdater(RenderLayer* rootRenderLayer)
: m_geometryMap(UseTransforms)
, m_rootRenderLayer(rootRenderLayer)
{
rootRenderLayer->updateDescendantDependentFlags();
}
-CompositingPropertyUpdater::~CompositingPropertyUpdater()
+CompositingInputsUpdater::~CompositingInputsUpdater()
{
}
-void CompositingPropertyUpdater::updateAncestorDependentProperties(RenderLayer* layer, UpdateType updateType, AncestorInfo info)
+void CompositingInputsUpdater::update(RenderLayer* layer, UpdateType updateType, AncestorInfo info)
{
- if (!layer->childNeedsToUpdateAncestorDependantProperties() && updateType != ForceUpdate)
+ if (!layer->childNeedsCompositingInputsUpdate() && updateType != ForceUpdate)
return;
m_geometryMap.pushMappingsToAncestor(layer, layer->parent());
@@ -32,14 +32,14 @@ void CompositingPropertyUpdater::updateAncestorDependentProperties(RenderLayer*
if (layer->hasCompositedLayerMapping())
info.enclosingCompositedLayer = layer;
- if (layer->needsToUpdateAncestorDependentProperties()) {
+ if (layer->needsCompositingInputsUpdate()) {
if (info.enclosingCompositedLayer)
info.enclosingCompositedLayer->compositedLayerMapping()->setNeedsGraphicsLayerUpdate();
updateType = ForceUpdate;
}
if (updateType == ForceUpdate) {
- RenderLayer::AncestorDependentProperties properties;
+ RenderLayer::CompositingInputs properties;
if (!layer->isRootLayer()) {
properties.clippedAbsoluteBoundingBox = enclosingIntRect(m_geometryMap.absoluteRect(layer->boundingBoxForCompositingOverlapTest()));
@@ -53,9 +53,9 @@ void CompositingPropertyUpdater::updateAncestorDependentProperties(RenderLayer*
properties.clippedAbsoluteBoundingBox.intersect(clipRect);
const RenderLayer* parent = layer->parent();
- properties.opacityAncestor = parent->isTransparent() ? parent : parent->ancestorDependentProperties().opacityAncestor;
- properties.transformAncestor = parent->hasTransform() ? parent : parent->ancestorDependentProperties().transformAncestor;
- properties.filterAncestor = parent->hasFilter() ? parent : parent->ancestorDependentProperties().filterAncestor;
+ properties.opacityAncestor = parent->isTransparent() ? parent : parent->compositingInputs().opacityAncestor;
+ properties.transformAncestor = parent->hasTransform() ? parent : parent->compositingInputs().transformAncestor;
+ properties.filterAncestor = parent->hasFilter() ? parent : parent->compositingInputs().filterAncestor;
if (layer->renderer()->isOutOfFlowPositioned() && info.ancestorScrollingLayer && !layer->subtreeIsInvisible()) {
const RenderObject* container = layer->renderer()->containingBlock();
@@ -64,29 +64,29 @@ void CompositingPropertyUpdater::updateAncestorDependentProperties(RenderLayer*
}
}
- layer->updateAncestorDependentProperties(properties);
+ layer->updateCompositingInputs(properties);
}
if (layer->scrollsOverflow())
info.ancestorScrollingLayer = layer;
for (RenderLayer* child = layer->firstChild(); child; child = child->nextSibling())
- updateAncestorDependentProperties(child, updateType, info);
+ update(child, updateType, info);
m_geometryMap.popMappingsToAncestor(layer->parent());
- layer->clearChildNeedsToUpdateAncestorDependantProperties();
+ layer->clearChildNeedsCompositingInputsUpdate();
}
#if !ASSERT_DISABLED
-void CompositingPropertyUpdater::assertNeedsToUpdateAncestorDependantPropertiesBitsCleared(RenderLayer* layer)
+void CompositingInputsUpdater::assertNeedsCompositingInputsUpdateBitsCleared(RenderLayer* layer)
{
- ASSERT(!layer->childNeedsToUpdateAncestorDependantProperties());
- ASSERT(!layer->needsToUpdateAncestorDependentProperties());
+ ASSERT(!layer->childNeedsCompositingInputsUpdate());
+ ASSERT(!layer->needsCompositingInputsUpdate());
for (RenderLayer* child = layer->firstChild(); child; child = child->nextSibling())
- assertNeedsToUpdateAncestorDependantPropertiesBitsCleared(child);
+ assertNeedsCompositingInputsUpdateBitsCleared(child);
}
#endif

Powered by Google App Engine
This is Rietveld 408576698