Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 321583006: Remove CanBeBound & BindMeasurementJavaScript since they are not used. (Closed)

Created:
6 years, 6 months ago by nednguyen
Modified:
6 years, 6 months ago
Reviewers:
dtu, tonyg, chrishenry
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove CanBeBound & BindMeasurementJavaScript since they are not used anywhere. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275650

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -71 lines) Patch
M tools/telemetry/telemetry/page/actions/page_action.py View 1 chunk +0 lines, -21 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/pinch.py View 1 chunk +0 lines, -10 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/scroll.py View 1 chunk +0 lines, -10 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/scroll_bounce.py View 1 chunk +0 lines, -10 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/swipe.py View 1 chunk +0 lines, -10 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/tap.py View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
nednguyen
6 years, 6 months ago (2014-06-06 22:49:30 UTC) #1
chrishenry
lgtm
6 years, 6 months ago (2014-06-06 22:52:48 UTC) #2
tonyg
lgtm yay for red patches
6 years, 6 months ago (2014-06-06 22:55:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/321583006/1
6 years, 6 months ago (2014-06-06 22:57:17 UTC) #4
dtu
lgtm So glad for this.
6 years, 6 months ago (2014-06-06 23:46:15 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-07 02:47:44 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 08:38:30 UTC) #7
Message was sent while issue was closed.
Change committed as 275650

Powered by Google App Engine
This is Rietveld 408576698