tools/telemetry/telemetry/page/actions/scroll.py - Issue 321583006: Remove CanBeBound & BindMeasurementJavaScript since they are not used.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/actions/scroll.py

Issue 321583006: Remove CanBeBound & BindMeasurementJavaScript since they are not used. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/actions/scroll.py

diff --git a/tools/telemetry/telemetry/page/actions/scroll.py b/tools/telemetry/telemetry/page/actions/scroll.py

index 2f6dbd71696ebb406cf529622a44236d9c2d20fd..4042c2c9ffc014ffbd785ba2afd67b15d6b1813b 100644

--- a/tools/telemetry/telemetry/page/actions/scroll.py

+++ b/tools/telemetry/telemetry/page/actions/scroll.py

@@ -98,13 +98,3 @@ class ScrollAction(GestureAction):

gesture_source_type))

tab.WaitForJavaScriptExpression('window.__scrollActionDone', 60)

- def CanBeBound(self):

- return True

- def BindMeasurementJavaScript(self, tab, start_js, stop_js):

- # Make the scroll action start and stop measurement automatically.

- tab.ExecuteJavaScript("""

- window.__scrollAction.beginMeasuringHook = function() { %s };

- window.__scrollAction.endMeasuringHook = function() { %s };

- """ % (start_js, stop_js))

« no previous file with comments | « tools/telemetry/telemetry/page/actions/pinch.py ('k') | tools/telemetry/telemetry/page/actions/scroll_bounce.py » ('j') | no next file with comments »