Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: tools/telemetry/telemetry/page/actions/page_action.py

Issue 321583006: Remove CanBeBound & BindMeasurementJavaScript since they are not used. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/actions/pinch.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/actions/page_action.py
diff --git a/tools/telemetry/telemetry/page/actions/page_action.py b/tools/telemetry/telemetry/page/actions/page_action.py
index 9388ca2e7876e2bf2590b6819dcdefd58252784c..b30f575161e86e6896db959ae44e46a053af77f4 100644
--- a/tools/telemetry/telemetry/page/actions/page_action.py
+++ b/tools/telemetry/telemetry/page/actions/page_action.py
@@ -41,24 +41,3 @@ class PageAction(object):
def CleanUp(self, tab):
pass
-
- def CanBeBound(self):
- """If this class implements BindMeasurementJavaScript, override CanBeBound
- to return True so that a test knows it can bind measurements."""
- return False
-
- def BindMeasurementJavaScript(
- self, tab, start_js, stop_js): # pylint: disable=W0613
- """Let this action determine when measurements should start and stop.
-
- A measurement can call this method to provide the action
- with JavaScript code that starts and stops measurements. The action
- determines when to execute the provided JavaScript code, for more accurate
- timings.
-
- Args:
- tab: The tab to do everything on.
- start_js: JavaScript code that starts measurements.
- stop_js: JavaScript code that stops measurements.
- """
- raise Exception('This action cannot be bound.')
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/actions/pinch.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698