tools/telemetry/telemetry/page/actions/scroll_bounce.py - Issue 321583006: Remove CanBeBound & BindMeasurementJavaScript since they are not used.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/actions/scroll_bounce.py

Issue 321583006: Remove CanBeBound & BindMeasurementJavaScript since they are not used. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/actions/scroll_bounce.py

diff --git a/tools/telemetry/telemetry/page/actions/scroll_bounce.py b/tools/telemetry/telemetry/page/actions/scroll_bounce.py

index 6bdd25f212fff3823aca1949b311f277fd16301f..5ca2f7217970cf2ed6451f654952f616ffe70976 100644

--- a/tools/telemetry/telemetry/page/actions/scroll_bounce.py

+++ b/tools/telemetry/telemetry/page/actions/scroll_bounce.py

@@ -109,13 +109,3 @@ class ScrollBounceAction(GestureAction):

speed))

tab.WaitForJavaScriptExpression('window.__scrollBounceActionDone', 60)

- def CanBeBound(self):

- return True

- def BindMeasurementJavaScript(self, tab, start_js, stop_js):

- # Make the scroll bounce action start and stop measurement automatically.

- tab.ExecuteJavaScript("""

- window.__scrollBounceAction.beginMeasuringHook = function() { %s };

- window.__scrollBounceAction.endMeasuringHook = function() { %s };

- """ % (start_js, stop_js))

« no previous file with comments | « tools/telemetry/telemetry/page/actions/scroll.py ('k') | tools/telemetry/telemetry/page/actions/swipe.py » ('j') | no next file with comments »