Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 320403002: Pull out common code from client and host versions of LogToServer (Closed)

Created:
6 years, 6 months ago by Lambros
Modified:
6 years, 5 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Visibility:
Public.

Description

Pull out common code from client and host versions of LogToServer Also added unittests for client code. TEST=unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282193

Patch Set 1 #

Total comments: 4

Patch Set 2 : rebase #

Patch Set 3 : Rename classes and fix nits #

Patch Set 4 : Fix try failures #

Total comments: 2

Patch Set 5 : Add unittests for LogToServer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+606 lines, -988 lines) Patch
A remoting/client/client_status_logger.h View 1 2 1 chunk +59 lines, -0 lines 0 comments Download
A + remoting/client/client_status_logger.cc View 1 2 6 chunks +20 lines, -74 lines 0 comments Download
A remoting/client/client_status_logger_unittest.cc View 1 2 3 4 1 chunk +155 lines, -0 lines 0 comments Download
M remoting/client/jni/chromoting_jni_instance.h View 1 2 2 chunks +2 lines, -5 lines 0 comments Download
M remoting/client/jni/chromoting_jni_instance.cc View 1 2 5 chunks +8 lines, -8 lines 0 comments Download
D remoting/client/log_to_server.h View 1 chunk +0 lines, -90 lines 0 comments Download
D remoting/client/log_to_server.cc View 1 chunk +0 lines, -194 lines 0 comments Download
A remoting/host/host_status_logger.h View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
A remoting/host/host_status_logger.cc View 1 2 3 1 chunk +73 lines, -0 lines 0 comments Download
A + remoting/host/host_status_logger_unittest.cc View 1 2 8 chunks +47 lines, -45 lines 0 comments Download
M remoting/host/it2me/it2me_host.h View 1 2 4 chunks +5 lines, -6 lines 0 comments Download
M remoting/host/it2me/it2me_host.cc View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M remoting/host/it2me/it2me_native_messaging_host.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
D remoting/host/log_to_server.h View 1 chunk +0 lines, -85 lines 0 comments Download
D remoting/host/log_to_server.cc View 1 chunk +0 lines, -122 lines 0 comments Download
D remoting/host/log_to_server_unittest.cc View 1 chunk +0 lines, -256 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
A + remoting/jingle_glue/log_to_server.h View 1 2 3 4 chunks +6 lines, -36 lines 0 comments Download
A + remoting/jingle_glue/log_to_server.cc View 3 chunks +4 lines, -52 lines 0 comments Download
A remoting/jingle_glue/log_to_server_unittest.cc View 1 2 3 4 1 chunk +93 lines, -0 lines 0 comments Download
M remoting/jingle_glue/server_log_entry_unittest.h View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
M remoting/jingle_glue/server_log_entry_unittest.cc View 1 2 3 4 1 chunk +40 lines, -0 lines 0 comments Download
M remoting/remoting_host.gypi View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/remoting_srcs.gypi View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M remoting/remoting_test.gypi View 1 2 3 4 4 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Lambros
6 years, 6 months ago (2014-06-09 23:20:16 UTC) #1
Sergey Ulanov
Thank you for the cleanup. I don't think inheritance is appropriate here. It would be ...
6 years, 5 months ago (2014-06-27 20:50:10 UTC) #2
Lambros
Done, ptal. https://codereview.chromium.org/320403002/diff/1/remoting/host/log_to_server_host.cc File remoting/host/log_to_server_host.cc (right): https://codereview.chromium.org/320403002/diff/1/remoting/host/log_to_server_host.cc#newcode32 remoting/host/log_to_server_host.cc:32: bool connected) { On 2014/06/27 20:50:10, Sergey ...
6 years, 5 months ago (2014-07-01 22:56:17 UTC) #3
Sergey Ulanov
Looks mostly good, except that I think we need unittests for LogToServer. https://codereview.chromium.org/320403002/diff/60001/remoting/jingle_glue/log_to_server.h File remoting/jingle_glue/log_to_server.h ...
6 years, 5 months ago (2014-07-07 22:35:45 UTC) #4
Lambros
Added unittests, ptal. https://codereview.chromium.org/320403002/diff/60001/remoting/jingle_glue/log_to_server.h File remoting/jingle_glue/log_to_server.h (right): https://codereview.chromium.org/320403002/diff/60001/remoting/jingle_glue/log_to_server.h#newcode27 remoting/jingle_glue/log_to_server.h:27: class LogToServer : public base::NonThreadSafe, On ...
6 years, 5 months ago (2014-07-09 01:12:23 UTC) #5
Sergey Ulanov
lgtm
6 years, 5 months ago (2014-07-09 18:13:29 UTC) #6
Lambros
The CQ bit was checked by lambroslambrou@chromium.org
6 years, 5 months ago (2014-07-09 21:18:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/320403002/80001
6 years, 5 months ago (2014-07-09 21:20:17 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 00:36:10 UTC) #9
Message was sent while issue was closed. 
Change committed as 282193

Powered by Google App Engine
This is Rietveld 408576698