Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: remoting/jingle_glue/server_log_entry_unittest.cc

Issue 320403002: Pull out common code from client and host versions of LogToServer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add unittests for LogToServer Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/jingle_glue/server_log_entry_unittest.h ('k') | remoting/remoting_host.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/jingle_glue/server_log_entry_unittest.cc
diff --git a/remoting/jingle_glue/server_log_entry_unittest.cc b/remoting/jingle_glue/server_log_entry_unittest.cc
index b92feb2053049515f23866ceb6aa9a9ff3eb1f08..824224df6a45a892bedf844a5967b98413870346 100644
--- a/remoting/jingle_glue/server_log_entry_unittest.cc
+++ b/remoting/jingle_glue/server_log_entry_unittest.cc
@@ -6,13 +6,53 @@
#include <sstream>
+#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/libjingle/source/talk/xmllite/xmlelement.h"
+using buzz::QName;
using buzz::XmlAttr;
using buzz::XmlElement;
namespace remoting {
+const char kJabberClientNamespace[] = "jabber:client";
+const char kChromotingNamespace[] = "google:remoting";
+
+XmlElement* GetLogElementFromStanza(XmlElement* stanza) {
+ if (stanza->Name() != QName(kJabberClientNamespace, "iq")) {
+ ADD_FAILURE() << "Expected element 'iq'";
+ return NULL;
+ }
+ XmlElement* log_element = stanza->FirstChild()->AsElement();
+ if (log_element->Name() != QName(kChromotingNamespace, "log")) {
+ ADD_FAILURE() << "Expected element 'log'";
+ return NULL;
+ }
+ if (log_element->NextChild()) {
+ ADD_FAILURE() << "Expected only 1 child of 'iq'";
+ return NULL;
+ }
+ return log_element;
+}
+
+XmlElement* GetSingleLogEntryFromStanza(XmlElement* stanza) {
+ XmlElement* log_element = GetLogElementFromStanza(stanza);
+ if (!log_element) {
+ // Test failure already recorded, so just return NULL here.
+ return NULL;
+ }
+ XmlElement* entry = log_element->FirstChild()->AsElement();
+ if (entry->Name() != QName(kChromotingNamespace, "entry")) {
+ ADD_FAILURE() << "Expected element 'entry'";
+ return NULL;
+ }
+ if (entry->NextChild()) {
+ ADD_FAILURE() << "Expected only 1 child of 'log'";
+ return NULL;
+ }
+ return entry;
+}
+
bool VerifyStanza(
const std::map<std::string, std::string>& key_value_pairs,
const std::set<std::string> keys,
« no previous file with comments | « remoting/jingle_glue/server_log_entry_unittest.h ('k') | remoting/remoting_host.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698