Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: remoting/jingle_glue/log_to_server.h

Issue 320403002: Pull out common code from client and host versions of LogToServer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add unittests for LogToServer Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/remoting_me2me_host.cc ('k') | remoting/jingle_glue/log_to_server.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/jingle_glue/log_to_server.h
diff --git a/remoting/client/log_to_server.h b/remoting/jingle_glue/log_to_server.h
similarity index 55%
rename from remoting/client/log_to_server.h
rename to remoting/jingle_glue/log_to_server.h
index cd70ff538469c1047c6fc5edc2d6d748565cbfdb..0414d6e56898b94bc2d00b4a4bb68f15b1808932 100644
--- a/remoting/client/log_to_server.h
+++ b/remoting/jingle_glue/log_to_server.h
@@ -2,19 +2,16 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef REMOTING_CLIENT_LOG_TO_SERVER_H_
-#define REMOTING_CLIENT_LOG_TO_SERVER_H_
+#ifndef REMOTING_JINGLE_GLUE_LOG_TO_SERVER_H_
+#define REMOTING_JINGLE_GLUE_LOG_TO_SERVER_H_
#include <deque>
#include <map>
#include <string>
#include "base/threading/non_thread_safe.h"
-#include "base/time/time.h"
#include "remoting/jingle_glue/server_log_entry.h"
#include "remoting/jingle_glue/signal_strategy.h"
-#include "remoting/protocol/connection_to_host.h"
-#include "remoting/protocol/errors.h"
namespace buzz {
class XmlElement;
@@ -22,15 +19,8 @@ class XmlElement;
namespace remoting {
-class ChromotingStats;
class IqSender;
-// Temporary namespace to prevent conflict with the same-named class in
-// remoting/host when linking unittests.
-//
-// TODO(lambroslambrou): Remove this and factor out any shared code.
-namespace client {
-
// LogToServer sends log entries to a server.
// The contents of the log entries are described in server_log_entry.cc.
// They do not contain any personally identifiable information.
@@ -42,26 +32,18 @@ class LogToServer : public base::NonThreadSafe,
const std::string& directory_bot_jid);
virtual ~LogToServer();
- // Logs a session state change.
- void LogSessionStateChange(protocol::ConnectionToHost::State state,
- protocol::ErrorCode error);
- void LogStatistics(remoting::ChromotingStats* statistics);
-
// SignalStrategy::Listener interface.
virtual void OnSignalStrategyStateChange(
SignalStrategy::State state) OVERRIDE;
virtual bool OnSignalStrategyIncomingStanza(
const buzz::XmlElement* stanza) OVERRIDE;
- private:
void Log(const ServerLogEntry& entry);
- void SendPendingEntries();
- // Generates a new random session ID.
- void GenerateSessionId();
+ ServerLogEntry::Mode mode() { return mode_; }
- // Expire the session ID if the maximum duration has been exceeded.
- void MaybeExpireSessionId();
+ private:
+ void SendPendingEntries();
ServerLogEntry::Mode mode_;
SignalStrategy* signal_strategy_;
@@ -70,21 +52,9 @@ class LogToServer : public base::NonThreadSafe,
std::deque<ServerLogEntry> pending_entries_;
- // A randomly generated session ID to be attached to log messages. This
- // is regenerated at the start of a new session.
- std::string session_id_;
-
- // Start time of the session.
- base::TimeTicks session_start_time_;
-
- // Time when the session ID was generated.
- base::TimeTicks session_id_generation_time_;
-
DISALLOW_COPY_AND_ASSIGN(LogToServer);
};
-} // namespace client
-
} // namespace remoting
-#endif // REMOTING_CLIENT_LOG_TO_SERVER_H_
+#endif // REMOTING_JINGLE_GLUE_LOG_TO_SERVER_H_
« no previous file with comments | « remoting/host/remoting_me2me_host.cc ('k') | remoting/jingle_glue/log_to_server.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698